Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP Config Module Doesn't have token_bound_cidrs support #397

Open
adawalli opened this issue Mar 8, 2022 · 3 comments · May be fixed by #446
Open

LDAP Config Module Doesn't have token_bound_cidrs support #397

adawalli opened this issue Mar 8, 2022 · 3 comments · May be fixed by #446

Comments

@adawalli
Copy link
Contributor

adawalli commented Mar 8, 2022

First off, love this module - amazing work.

Would you consider adding token_bound_cidrs to the hashivault_auth_ldap module? Thankfully, you have this on OIDC roles and approles and it just appears to be missing on this one login method.

Thank you for your consideration!

https://www.vaultproject.io/api/auth/ldap#token_bound_cidrs

@TerryHowe
Copy link
Owner

Something like this probably https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_oidc_auth_role.py#L65

Not hard to do, just adding the docs, parameters and any desired state type logic

@adawalli
Copy link
Contributor Author

adawalli commented Mar 9, 2022

I can submit a PR tomorrow

@adawalli
Copy link
Contributor Author

adawalli commented Mar 9, 2022

Unfortunately, HVAC doesn't support CIDRs yet for LDAP - I will have to get it added there first.

How hard will it be to add guards in the code for folks that have HVAC <= the current version?

@ceesios ceesios linked a pull request Jul 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants