Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuring allowed_other_sans parameter in hashivault_pki_role broken #449

Open
lesinjan opened this issue Aug 11, 2023 · 2 comments
Open

Comments

@lesinjan
Copy link

Hello!
It seems that configuration of allowed_other_sans parameter in hashivault_pki_role is broken and fails with "config item 'allowed_other_sans' has wrong data format" for any valid value. As far as I can tell it is due to wrong parameter type where it was supposed to get changed from 'str' to 'list', but was changes to 'type'.

https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_pki_role.py#L127

@TerryHowe
Copy link
Owner

Sounds like a docs bug and a one liner. Do you want to submit a PR?

@lesinjan
Copy link
Author

Not just a docs bug, as it seems documentation is also used for simple parameter validation. But you are right, should be a one liner.
As for PR, it seems I can't create a branch for the issue. Missing the button.

sschmittsva added a commit to sschmittsva/ansible-modules-hashivault that referenced this issue Oct 19, 2023
As discussed in TerryHowe#449, the type needs to be `list` instead of `type`.
TerryHowe added a commit that referenced this issue Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants