Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite Button doesn't indicate status / wrong color #1266

Open
JustinWeyenberg opened this issue Jul 15, 2022 · 0 comments
Open

Favorite Button doesn't indicate status / wrong color #1266

JustinWeyenberg opened this issue Jul 15, 2022 · 0 comments

Comments

@JustinWeyenberg
Copy link

JustinWeyenberg commented Jul 15, 2022

Describe the bug
In the schedule view (https://that.us/events/wi/2022/schedule/) favorited sessions are not visually indicating they are favorited.

To Reproduce
Steps to reproduce the behavior:

  1. Go to schedule (https://that.us/events/wi/2022/schedule/)
  2. Click on the Favorite button for a session
  3. See no change or difference in the button from an non-favorited session

Expected behavior
The button should indicate the session is favorited (it looks like the intention is by way of a text-red-500 CSS class on the button, though for accessibility I'd prefer a different icon for each status as even with a mild color deficiency it is hard for me to see the red vs gray).

Screenshots
In this image the John Ptacek and Benjamin Gavin sessions are favorited, but not the Dave Aronson session.
image

The text-gray-700 and text-red-500 CSS classes are applied to the button but the text-gray-700 is overriding.
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Brave and Edge
  • Version: Brave 1.39.122 and Edge 103.0.1264.49

Additional context
It seems the text-gray-700 CSS class must have precedence in the stylesheet to the text-red-500. Either precedence needs to be changed or the styles need to be applied more dynamically from my perspective.

@JustinWeyenberg JustinWeyenberg changed the title Favorite Button is wrong color when session is favorited (no visual indication) Favorite Button doesn't indicate status / wrong color Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant