Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make "favorited by" heart clickable #1436

Open
JoshuaKGoldberg opened this issue Jul 19, 2023 · 1 comment
Open

Feature: Make "favorited by" heart clickable #1436

JoshuaKGoldberg opened this issue Jul 19, 2023 · 1 comment
Assignees
Labels
enhancement Improvements to existing features good first issue Good for newcomers

Comments

@JoshuaKGoldberg
Copy link

Is your feature request related to a problem? Please describe.

In the logged in view of activity pages, the ❤️ favorited by: is not clickable. But I keep clicking it because in activities with multiple paragraphs, the top-right ❤️ Favorite button is scrolled out of view.

Describe the solution you'd like

Can we make the heart icon clickable?

Describe alternatives you've considered

Hmm, perhaps adding a copy of the top-right button? IMO it would look odd on activities with a small enough amount of text that you'd see both...

Additional context

I'd chatted with @csell5 briefly on the Slack about this. Happy to contribute the feature!

@theClarkSell theClarkSell added enhancement Improvements to existing features good first issue Good for newcomers labels Jul 19, 2023
@theClarkSell
Copy link
Member

theClarkSell commented Jul 19, 2023

All your's @JoshuaKGoldberg. A couple of things to be aware of.

  • The list of people who favorited that session is cached and refreshes, I think, every 15m or so.
  • Because of that ^^ when you favorite and unfavorite, you don't see your own mug shot appear in the list until that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants