Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fee Collector #394

Closed
wants to merge 19 commits into from
Closed

Add Fee Collector #394

wants to merge 19 commits into from

Conversation

Lomet
Copy link
Member

@Lomet Lomet commented Jan 27, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2024 •
edited
Loading

Gas Test Report 📊

The gas test results are as follows:

LockDealNFT

Contract Method Min Max Avg # calls
LockDealNFT approvePoolTransfers(bool) 22087 43999 33043 8
LockDealNFT renounceOwnership() - - 23339 1
LockDealNFT safeTransferFrom(address,address,uint256,bytes) 303921 1297279 653683 28
LockDealNFT safeTransferFrom(address,address,uint256) 120185 353404 208416 31
LockDealNFT setApprovedContract(address,bool) 28194 50594 48294 65
LockDealNFT setBaseURI(string) 51149 79688 70175 3
LockDealNFT transferFrom(address,address,uint256) 101262 119712 110487 2
LockDealNFT transferOwnership(address) - - 28694 1
LockDealNFT updateAllMetadata() - - 24533 2

Simple Providers

Contract Method Min Max Avg # calls
DealProvider createNewPool(address[],uint256[],bytes) 261376 302566 273454 69
FeeDealProvider createNewPool(address[],uint256[],bytes) 295784 301684 297477 4
LockDealProvider createNewPool(address[],uint256[],bytes) 296277 311795 307018 15
TimedDealProvider createNewPool(address[],uint256[],bytes) 356451 385186 368477 32

Advanced Providers

Contract Method Min Max Avg # calls
BundleProvider createNewPool(address[],uint256[][],bytes) 917520 931520 931095 33
RefundProvider createNewRefundPool(address[],uint256[],bytes,bytes) 1272333 1376988 1366855 32

Builders

Contract Method Min Max Avg # calls
SimpleBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[],bytes) 2050261 27353504 12399933 18
SimpleRefundBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[][],bytes,bytes) 4840836 47841888 23708476 18

Deployments

Contract Min Max Avg % of limit
BundleProvider - - 2495484 1.9 %
CollateralProvider - - 3175915 2.4 %
DealProvider - - 1494667 1.1 %
ERC20Token - - 790840 0.6 %
FeeCollector - - 590310 0.5 %
FeeDealProvider 1675203 1675215 1675212 1.3 %
FeeLockProvider - - 1667617 1.3 %
FeeTimedProvider - - 1904055 1.5 %
LockDealProvider 1637276 1637288 1637285 1.3 %
RefundProvider - - 3248401 2.5 %
SimpleBuilder - - 1137247 0.9 %
SimpleRefundBuilder - - 2166884 1.7 %
TimedDealProvider - - 1873839 1.4 %

@codecov Codecov
Copy link

codecov bot commented Jan 27, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (92f66c9) 99.86% compared to head (22b020b) 99.34%.
Report is 2 commits behind head on master.

Files Patch % Lines
contracts/interfaces/FundsManager.sol 0.00% 3 Missing ⚠️
contracts/FeeProvider/FeeCollector.sol 94.73% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   99.86%   99.34%   -0.52%     
==========================================
  Files          22       28       +6     
  Lines         723      766      +43     
  Branches      177      188      +11     
==========================================
+ Hits          722      761      +39     
- Misses          1        5       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YouStillAlive YouStillAlive marked this pull request as draft February 1, 2024 12:04
This was linked to issues Feb 2, 2024
add tests for fee-collector and providers #395
Open
add Refund Provider with fee #396
Open
FeeCollector should use LockDealNFT royalties to know fee amount #397
Open
@Lomet Lomet added the wontfix This will not be worked on label Feb 4, 2024
@Lomet Lomet closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
2 participants
@Lomet @YouStillAlive