Added check for possible duplication of middleware in groups

Author: Andrey Helldar

src/ServiceProvider.php

@@ -8,26 +8,43 @@
 
 final class ServiceProvider extends BaseServiceProvider
 {
+    protected $groups = ['web', 'api'];
+
     public function boot(): void
     {
-        $this->prepend('web', SetHeaderMiddleware::class);
-        $this->prepend('api', SetHeaderMiddleware::class);
+        foreach ($this->groups as $group) {
+            $this->prepend($group, SetHeaderMiddleware::class);
+        }
     }
 
     protected function prepend(string $group, string $middleware): void
     {
-        if ($this->hasGroup($group)) {
+        if ($this->has($group, $middleware)) {
             $this->resolve()->prependMiddlewareToGroup($group, $middleware);
         }
     }
 
+    protected function has(string $group, string $middleware): bool
+    {
+        return $this->hasGroup($group) && $this->doesntMiddleware($group, $middleware);
+    }
+
     protected function hasGroup(string $group): bool
     {
         $groups = $this->getGroups();
 
         return isset($groups[$group]);
     }
 
+    protected function doesntMiddleware(string $group, string $middleware): bool
+    {
+        $groups = $this->getGroups();
+
+        $group = $groups[$group];
+
+        return ! in_array($middleware, $group);
+    }
+
     protected function getGroups(): array
     {
         return $this->resolve()->getMiddlewareGroups();

tests/Middlewares/DuplicateTest.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Tests\Middlewares;
+
+use Helldar\LaravelJsonResponse\Middlewares\SetHeaderMiddleware;
+use Tests\TestCase;
+
+final class DuplicateTest extends TestCase
+{
+    public function testCount()
+    {
+        foreach ($this->getMiddlewareGroups() as $group => $middlewares) {
+            $count = count(array_filter($middlewares, static function ($middleware) {
+                return $middleware === SetHeaderMiddleware::class;
+            }));
+
+            $this->assertSame(1, $count, "The count of registered intermediaries is $count for $group, should be 1.");
+        }
+    }
+}

tests/TestCase.php

@@ -3,6 +3,7 @@
 namespace Tests;
 
 use Helldar\LaravelJsonResponse\ServiceProvider;
+use Illuminate\Contracts\Http\Kernel;
 use Orchestra\Testbench\TestCase as BaseTestCase;
 
 abstract class TestCase extends BaseTestCase
@@ -27,4 +28,9 @@ protected function setRoutes($app): void
             return ['data' => 'Hello, JSON!'];
         })->middleware('api');
     }
+
+    protected function getMiddlewareGroups(): array
+    {
+        return $this->app->make(Kernel::class)->getMiddlewareGroups();
+    }
 }