Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add length check for toolRequestParts in fromOpenAiChoice #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pedi
Copy link

@pedi pedi commented Sep 3, 2024

This pull request is related to:

  • A bug
  • A new feature
  • Documentation
  • Other (please specify)

I have checked the following:

  • I have read and understood the contribution guidelines and the code of conduct;
  • I have added new tests (for bug fixes/features);
  • I have added/updated the documentation (for bug fixes / features).

Description:
Please check description in the original issue

Related issues:
Fix #137

@pedi pedi requested a review from Dabolus as a code owner September 3, 2024 04:26
Copy link
Collaborator

@xavidop xavidop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I see that you have commited the compile files, can you please remove them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genkitx-openai generate response candidate not properly generated when streamingCallback is used
2 participants