Allow basic expressions #9
Conversation
| def safe_module_function?(DockYardWeb.EmployeeView, :random_avatar_uri), do: true | ||
| def safe_module_function?(DockYardWeb.EmployeeView, :display_name), do: true | ||
| def safe_module_function?(DockYardWeb.PostView, :illustration), do: true | ||
| def safe_module_function?(DockYardWeb.PostView, :post_path), do: true | ||
| def safe_module_function?(DockYardWeb.PostView, :author_avatar_url), do: true | ||
| def safe_module_function?(DockYard.ClientLeads, :change_client_lead_form), do: true |
There was a problem hiding this comment.
I need to think of a way to remove this, it's trying to validate AST like this one:
{:., [line: 95], [{:__aliases__, [line: 95], [:DockYardWeb, :EmployeeView]}, :display_name]}
There was a problem hiding this comment.
@alexandrexaviersm safe_code allows the application using it to specify its own safe functions. We are doing this in Beacon, but I need to expose a way for users using Beacon to tag safe functions. I am working on a PR for this now. You can remove these lines from this PR.
| def safe_module_function?(DockYardWeb.EmployeeView, :random_avatar_uri), do: true | ||
| def safe_module_function?(DockYardWeb.EmployeeView, :display_name), do: true | ||
| def safe_module_function?(DockYardWeb.PostView, :illustration), do: true | ||
| def safe_module_function?(DockYardWeb.PostView, :post_path), do: true | ||
| def safe_module_function?(DockYardWeb.PostView, :author_avatar_url), do: true | ||
| def safe_module_function?(DockYard.ClientLeads, :change_client_lead_form), do: true |
There was a problem hiding this comment.
@alexandrexaviersm safe_code allows the application using it to specify its own safe functions. We are doing this in Beacon, but I need to expose a way for users using Beacon to tag safe functions. I am working on a PR for this now. You can remove these lines from this PR.
|
|
||
| # def safe_module_function?(module, function) do | ||
| # IO.inspect("module: #{inspect(module)}") | ||
| # IO.inspect("function: #{function}") | ||
| # true | ||
| # end |
There was a problem hiding this comment.
| # def safe_module_function?(module, function) do | |
| # IO.inspect("module: #{inspect(module)}") | |
| # IO.inspect("function: #{function}") | |
| # true | |
| # end |
No description provided.