Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.getEstimatedLocation() returns nothing #406

Open
qeinz opened this issue Jan 6, 2022 · 3 comments
Open

client.getEstimatedLocation() returns nothing #406

qeinz opened this issue Jan 6, 2022 · 3 comments
Labels

Comments

@qeinz
Copy link

qeinz commented Jan 6, 2022

client.getEstimatedLocation() does not return a value, it is followed only by "".

@qeinz
Copy link
Author

qeinz commented Aug 4, 2023

am i wrong on this, or something else can explain this?

@rogermb rogermb added the bug label Aug 7, 2023
@rogermb
Copy link
Collaborator

rogermb commented Aug 7, 2023

Hi @qeinz, sorry for not getting back to you earlier!

I just looked into this, and it appears that support for clientlist's -location flag was first added in TS3 server version 3.13.0 (9 November 2020). If this flag is set, the server would send back a client_estimated_location for each client. Some time after this TS3 release, we added support for this client property in our API (which is just a thin wrapper around TS3's server query interface).

However, support for this flag & client property has subsequently been removed again in TS3 server version 3.13.6:

Server Release 3.13.6 9 June 2021

Fixed

  • Removed support for client_estimated_location property

Ever since then, yeah, you're probably just getting back an empty string as the client's location, which isn't ideal.
We'll likely remove this clientlist flag and the getEstimatedLocation getter in a later release of this API.

@qeinz
Copy link
Author

qeinz commented Aug 7, 2023

wow, adding a feature and then removing it, not so nice.

but thx for the information, i first thought it a problem on the part of the api, but good to know that this feature no longer exists at all xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants