Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add answers to warm up data model exercises in rails #23343

Open
DigitalKnight0 opened this issue Jan 19, 2022 · 12 comments
Open

Add answers to warm up data model exercises in rails #23343

DigitalKnight0 opened this issue Jan 19, 2022 · 12 comments
Labels
Content: Ruby on Rails Involves the Ruby on Rails course Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues

Comments

@DigitalKnight0
Copy link
Contributor

In the micro-reddit and private events project, The warmup part should have some answers linked so the users can compare their solutions to check whether they got it right or not. This helps in understanding associations better as they can research and rectify their mistake before starting the project. Currently, the only option they have is to post their solutions in the discord and ask for feedback, i think it might be better to link a repo or something with the correct answers

@rlmoser99
Copy link
Member

I do not think providing a repo with the answers is the best solution, because there can be different ways to implement associations. One thought that I've had in the past, but haven't developed is to create a test-driven approach to this. If the tests pass, you can be certain that you've written the associations correctly.

Is this something you'd be interested into working on?

@DigitalKnight0
Copy link
Contributor Author

@rlmoser99 I would love to, but i am myself currently on private events project and quite unsure of how testing is done with rails. I can prolly get started with some guidance but still your call

@rlmoser99
Copy link
Member

Ok. Before we decide on anything, let me touch base with the rest of the Rails team and see where this fits in with our current plans. Thanks for creating an issue to help find a way to provide feedback on those association warm ups. 👍

@dm-murphy
Copy link
Member

If you're seeking contributors to help add a test-driven approach here or elsewhere in the Rails curriculum, I'd love to help! :-)

@rlmoser99
Copy link
Member

@DigitalKnight0 @dm-murphy Quick Update: I've talked with a few other Rails maintainers and we think the TDD approach would be the best direction to go. The tests that I have mind (and have some sample ones written) will not be the typical Rails association tests, because they give away the answers... and are in general pretty pointless!

However, we don't want to create 8 new repos for Rails applications just for these warm-up exercises. So, it was suggested to use Rails Templates for this project. I am in the middle of another project, so it will take me some time to investigate how best to move forward with using templates and then I'll create issues to turn each warm-up exercise into a template that provides test files.

In the meantime, as you go through the Rails curriculum, I suggest learning about testing with codewithjason and FactoryBot.

@dm-murphy
Copy link
Member

@DigitalKnight0 @dm-murphy Quick Update: I've talked with a few other Rails maintainers and we think the TDD approach would be the best direction to go. The tests that I have mind (and have some sample ones written) will not be the typical Rails association tests, because they give away the answers... and are in general pretty pointless!

However, we don't want to create 8 new repos for Rails applications just for these warm-up exercises. So, it was suggested to use Rails Templates for this project. I am in the middle of another project, so it will take me some time to investigate how best to move forward with using templates and then I'll create issues to turn each warm-up exercise into a template that provides test files.

In the meantime, as you go through the Rails curriculum, I suggest learning about testing with codewithjason and FactoryBot.

Thanks for the update!

I'm almost done working through The Complete Guide to Rails Testing from codewithjason and I've found it really helpful and clear. Both the free content from the site and the full book could be great resources in the curriculum.

@CouchofTomato
Copy link
Member

I'm almost done working through The Complete Guide to Rails Testing from codewithjason and I've found it really helpful and clear. Both the free content from the site and the full book could be great resources in the curriculum.

I agree although the full book is a paid resource which means we could only at most add it to the additional resources section

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Jun 23, 2022
@rlmoser99
Copy link
Member

@TheOdinProject/rails-path I am not sure we have this idea documented with our newer plans for rails updates. I still very much want to see this, but it just hasn't been a top priority.

TheOdinProject/top-meta#173

@ChargrilledChook
Copy link
Member

@rlmoser99 Although the TDD idea is really good, is there perhaps a lower tech and simpler solution we could implement in the meantime? For someting like this section referenced in the original issue , we could simply add a spoiler tag in the lesson with solutions

This could be a good contribution for someone deep in the Rails path to make

@ChargrilledChook ChargrilledChook moved this from 🔖 Ready to 📋 Backlog in Ruby / Rails Public Curriculum Board Nov 15, 2022
@KevinMulhern KevinMulhern moved this to 📋 Backlog in Curriculum Mar 10, 2023
@KevinMulhern KevinMulhern moved this from 📋 Backlog to 🆕 Needs Review in Curriculum Mar 10, 2023
@github-actions
Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Mar 24, 2023
@github-actions github-actions bot removed the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Jun 20, 2023
@github-actions
Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues
Projects
Status: 📋 Backlog
Status: 🆕 Needs Review
Development

No branches or pull requests

7 participants