-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class Based Components: 'Additional resources' points to article which do not contain information on Class Based Components #29048
Comments
@TheOdinProject/react Can someone take a look please. |
Thanks @1Amal. The currently linked doc is their legacy docs and it looks like they've gotten rid of the codesandboxes that used to showcase class components in context. Of course, the legacy docs were what we wanted for this lesson precisely because we're exposing class components instead of function components, which is what the current version of the docs page would use. In all honesty, instead of finding a replacement resource, I'm happy for this additional resource to be removed entirely, and the default "no additional resources" placeholder put back instead. The state/lifecycle resource you linked won't be necessary since the current version of that (which does use class components) is assigned in the Lifecycle Methods lesson after. I'll assign this to you to remove. |
Hi @MaoShizhong & @CouchofTomato, |
Hi guys, |
Class Based Components: 'Additional resources' points to article which do not contain information on Class Based Components TheOdinProject#29048. Removed additional resources link and replaced with "It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum."
Checks
Describe your suggestion
Class Based Components lesson, Additional resources points to old Thinking in React document which does not contain information about Class Based Components eventhough lesson indicates:
More appropriate Doc would be State and Lifecycle from the Old React Docs.
Also replace the text to indicate they are legacy documents for clarity:
Also it seems the new Thinking in React do not contain information about Class based components. Please review the suggested article and if not appropriate please suggest a different doc/article.
Path
Node / JS
Lesson Url
https://www.theodinproject.com/lessons/node-path-react-new-class-based-components
(Optional) Discord Name
No response
(Optional) Additional Comments
Love "The Odin Project" and Open Source and really happy to make any contribution I can make !
Kind regards,
Amal
The text was updated successfully, but these errors were encountered: