Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class Based Components lesson fix for issue #29048 #29132

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

1Amal
Copy link
Contributor

@1Amal 1Amal commented Nov 26, 2024

Class Based Components: 'Additional resources' points to article which do not contain information on Class Based Components #29048. Removed additional resources link and replaced with "It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum."

Because

Class Based Components lesson: 'Additional resources' points to article which do not contain information on Class Based Components #29048. Removed additional resources link and replaced with "It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum." as per guidance from @MaoShizhong

This PR

  • Removed additional resources link and replaced with "no additional resources" placeholder

Issue

Closes #29048

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Class Based Components: 'Additional resources' points to article which do not
contain information on Class Based Components TheOdinProject#29048. Removed additional resources link and replaced with
"It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum."
@github-actions github-actions bot added the Content: React Involves the React course label Nov 26, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this issue!

Just have one suggestion to get the linter to pass in this PR, and then I'll be good to merge.

react/class_components/class_based_components.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
2 participants