Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent file naming #101

Open
DennisNeu opened this issue Jun 26, 2024 · 6 comments · May be fixed by #102
Open

consistent file naming #101

DennisNeu opened this issue Jun 26, 2024 · 6 comments · May be fixed by #102
Assignees
@DennisNeu
Labels
Status: Needs Review This issue/PR needs an initial or additional review

Comments

@DennisNeu
Copy link

The naming for exercise folders is not consistent.

The folders containing the seperate JS exercises started with a 0 for single digit number ("01_helloWorld"). Same case for CSS exercises.

The convention is broken here ("1_data_types"). I'd like to suggest renaming the exercise folders here to stick to the naming scheme.
@DennisNeu DennisNeu added the Status: Needs Review This issue/PR needs an initial or additional review label Jun 26, 2024
@CouchofTomato
Copy link
Member

@rlmoser99 Any input here?

@rlmoser99
Copy link
Member

I am not opposed to it matching the numbering convention in our other repos.

@CouchofTomato
Copy link
Member

@DennisNeu Is this something you wanted to work on?

@DennisNeu
Copy link
Author

DennisNeu commented Jun 28, 2024 via email

DennisNeu added a commit to DennisNeu/ruby-exercises-name-change that referenced this issue Jun 29, 2024
@DennisNeu
Change directory names to follow name convention
262fb29 
See issue TheOdinProject#101
@DennisNeu
Copy link
Author

@CouchofTomato Nvm, as per the contributing guidelines I won't create a pull request until the issue has been assigned.

@CouchofTomato
Copy link
Member

@DennisNeu All yours mate. Thanks.

@DennisNeu DennisNeu linked a pull request Jul 4, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DennisNeu DennisNeu

Labels
Status: Needs Review This issue/PR needs an initial or additional review
Projects
None yet
Milestone
No milestone
3 participants
@CouchofTomato @rlmoser99 @DennisNeu