Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks submitted and accepted by form are not displayed #33

Closed
arekm opened this issue Nov 22, 2023 · 15 comments
Closed

Benchmarks submitted and accepted by form are not displayed #33

arekm opened this issue Nov 22, 2023 · 15 comments
Assignees

Comments

@arekm
Copy link

arekm commented Nov 22, 2023

One of my submissions (probably 74857 or 74858) was accepted by form php script but is not showing up on the page.

Looking at other submission numbers there are tons of holes (aka submitted but missing on the web page results). I guess the problem comes from some server side data not added for drives ? (#9). Product links or something?

Could such results still be still shown, without missing data obviously? (when missing server side data gets added then it would show full data info).

API shows no content for these...


% curl -k -L https://pibenchmarks.com/api/benchmark/74857| jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   252  100   252    0     0    915      0 --:--:-- --:--:-- --:--:--   929
100    86    0    86    0     0    170      0 --:--:-- --:--:-- --:--:--     0
{
  "result": [
    "benchmark",
    "74857",
    ""
  ],
  "response_code": 204,
  "response_desc": "No Content 1"
}
% curl -k -L https://pibenchmarks.com/api/benchmark/74858| jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   252  100   252    0     0    723      0 --:--:-- --:--:-- --:--:--   730
100    86    0    86    0     0    149      0 --:--:-- --:--:-- --:--:--   149
{
  "result": [
    "benchmark",
    "74858",
    ""
  ],
  "response_code": 204,
  "response_desc": "No Content 1"
}
@FingerlessGlov3s
Copy link

I've submitted a few benchmarks on my Pi5 and it's been days with no sign of them on the website, but I can see there's benchmarks on the website from today. Not sure what's happening there.

@arekm
Copy link
Author

arekm commented Nov 26, 2023

You didn't mention if storage.sh actually told you that the data was submitted (it should via "Result submitted successfully and will appear live on https://pibenchmarks.com within a couple of minutes." message).

If it did but no results on web page the you came to correct issue.

If it didn't then try adding export LC_ALL=C at beginning of storage.sh script and your problem is most likely different issue than this. Probably #32.

@FingerlessGlov3s
Copy link

Adding export LC_ALL=C fixed the issue for me 🙂.

I have my locale set for en_GB.UTF-8 could that be the issue? 🤔

@arekm
Copy link
Author

arekm commented Nov 26, 2023

Yes. Web side of infrastructure doesn't handle utf8 well. LC_ALL=C is simplest solution to that. Issue #32 .

@TheRemote
Copy link
Owner

Thank you all for reporting this. I've added export LC_ALL=C to the top of storage.sh to prevent this in the future. Thanks again!

@arekm
Copy link
Author

arekm commented Nov 26, 2023

But this issue was mainly about "Could such results still be still shown, without missing data obviously? (when missing server side data gets added then it would show full data info)." ...

@TheRemote
Copy link
Owner

They are for missing boards. They aren't for missing storage devices right now mostly to keep it from being spammed with a bunch of blank image templates or really messed up/corrupted benchmarks.

This may change going forward but it hasn't really been a very big issue. It only happens if you're the first one ever to test a device on the site basically.

I hadn't done updates for a few months (the longest I've ever gone without doing them) and there were a few dozen new storage devices. I'm guessing the reason these posts started appearing is I just haven't been adding them as fast. It has worked this way for at least 4+ years though but if I keep getting behind I may indeed change that!

@technolhodgy
Copy link

I have been trying to submit benchmarks and it seems to be failing.

I added 2 lines to locale 'Storage.sh'
else
echo "Submission failed!"

So I only ever seen the "Submission failed!"

my attempts are
https://www.amazon.co.uk/gp/product/B09L7WD411?th=1
https://www.amazon.co.uk/gp/product/B091BG4HDW?th=1

using the prototype the same as https://pibenchmarks.com/user/pimoroni/
I have tried use my broadband and mobile tethering for internet connection to eliminated any reasons for fail at my end.

@arekm
Copy link
Author

arekm commented Dec 17, 2023

Add set -x at beginning of the script and see what is returned from server.

@technolhodgy
Copy link

Failed query in FormTools\Submissions, /var/www/storage/formtools/global/code/Submissions.class.php, line 204, error: SQLSTATE[HY000]: General error: 3988 Conversion from collation utf8mb3_general_ci into utf8mb4_bin impossible for parameter

@arekm
Copy link
Author

arekm commented Dec 17, 2023

Did you use this script or some other version?

https://raw.githubusercontent.com/TheRemote/PiBenchmarks/master/Storage.sh

(the web page submission form is known to be broken regarding utf8 handling but current version of the script has workaround for that)

@technolhodgy
Copy link

The same one, I just did a wget of that script and ran it.

@arekm
Copy link
Author

arekm commented Dec 17, 2023

Could you attach entire run from script with set -x added. I wonder where utf8 sneaks in despite LC_ALL=C.

@technolhodgy
Copy link

I just rememberedI commented out '##set' -x lol

Here it with it back in .
log.txt

@technolhodgy
Copy link

It is also a hardware match for https://pibenchmarks.com/benchmark/75582/
( it the actual same Crucial drive used in the test, as i took 2 drives into work for testing with )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants