Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Cropping Leaves Black Space on Some Images #82

Open
jrg94 opened this issue May 28, 2020 · 0 comments
Open

Image Cropping Leaves Black Space on Some Images #82

jrg94 opened this issue May 28, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jrg94
Copy link
Member

jrg94 commented May 28, 2020

Now that we scale images by width, we sometimes crop beyond the y-limit on images. As a result, a black space emerges on images which are smaller in height than the expected crop. I think we'll need to rework this to perform a horizontal crop so images are never resized to have a smaller height than the target size.

@jrg94 jrg94 added the bug Something isn't working label May 28, 2020
@jrg94 jrg94 self-assigned this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant