-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sleep Sort in Scala #4495
base: main
Are you sure you want to change the base?
Add Sleep Sort in Scala #4495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Dani-DEV28! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:
- Subscribe to the monthly newsletter
- Become a patron
- Join us on Discord
- And, check out the rest of the list which includes links to The Renegade Coder YouTube channel and Twitter account
Thanks for your help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the project requirements. The error messages are incorrect. In order to avoid a lot of duplication, I'd recommend making invalidChecker
just return true
or false
. If invalid, display the common error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better, but still not right. Please see the project requirements, specifically, this section: Sleep Sort Invalid Tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have a type mismatch error
I don't if I understand the test cases too well, but I think I found a issues with the test generated: I believe my issues with the test stem from that the extra (') in the in_param, because I do know if manual type all the test case on my local build they sort, but the test report that my code doesn't pass. I was wondering where can I go about modifying the test_sleep_sort.py file, because when I modify it directly, it regenerate to before modification after running the glotter test command |
The |
If you are running glotter locally, when prompted for the parameter, do not use the single quote. For example, you would enter "9, 8, 7, 6, 5, 4, 3, 2, 1". |
According to this article, using |
One final comment, when you are ready to do the final submission, please remove all the commented out code. It adds clutter. |
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.
Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation
I Am Adding a New Code Snippet in an Existing Language
Other Notes
Modify the .gitignore to exclude .metals and .scala-build