Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden Controls in the Options Menu #2569

Open
DevGeniusCode opened this issue Dec 14, 2024 · 2 comments
Open

Hidden Controls in the Options Menu #2569

DevGeniusCode opened this issue Dec 14, 2024 · 2 comments
Labels
Enhancement Is new feature or request GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker

Comments

@DevGeniusCode
Copy link
Contributor

DevGeniusCode commented Dec 14, 2024

Issue: Hidden Controls in the Options Menu

Description:
While reviewing the file OptionsMenu.wnd, I found several controls that were hidden and not displayed in the UI. Below is a list of these controls, along with my findings and questions about their functionality.

TEXT = "GUI:MouseType";
NAME = "OptionsMenu.wnd:RadioLow";
NAME = "OptionsMenu.wnd:RadioMedium";
NAME = "OptionsMenu.wnd:RadioHigh";

NAME = "OptionsMenu.wnd:ComboBoxAntiAliasing";
NAME = "OptionsMenu.wnd:CheckLanguageFilter";
NAME = "OptionsMenu.wnd:ButtonKeyboardOptions";
NAME = "OptionsMenu.wnd:CheckBoxSaveCamera";
NAME = "OptionsMenu.wnd:CheckBoxUseCamera";
NAME = "OptionsMenu.wnd:CheckBoxDrawAnchor";
NAME = "OptionsMenu.wnd:CheckBoxMoveAnchor";
; In WinAdvancedDisplayOptions
NAME = "OptionsMenu.wnd:CheckUnlockFPS";

Findings:

  1. CheckBoxSaveCamera

    • Effect: On/Off save the player’s camera state for replays.
  2. CheckBoxUseCamera

    • Effect: On/Off the player’s camera during replays.
  3. CheckBoxDrawAnchor

    • Effect: Displays the original position of the mouse pointer ( a "+" marker ) when right-click dragging.
  4. CheckLanguageFilter

    • Expected Effect: Toggles the profanity filter.
    • Issue: I couldn’t successfully disable the filter.
  5. ButtonKeyboardOptions

    • Issue: Clicking this button crashes the game.
  6. CheckUnlockFPS

    • Expected Effect: Unlocks the frame rate limit of 30 FPS, allowing higher frame rates. This is primarily intended for benchmarking purposes.
    • Issue: The feature does not seem to function, even when tested without GenTool.

Unknown Behavior:

  1. MouseType (Low/Meduim/High paramters)
  2. ComboBoxAntiAliasing (off/Low/High paramters)
  3. CheckBoxMoveAnchor

Questions:

  1. UI Restoration:

    • Which of these hidden controls should be restored to the UI? , I suugest the camera-related controls (CheckBoxSaveCamera, CheckBoxUseCamera)?
  2. General Guidance:

    • Are there any existing references or documentation about these controls to help clarify their purpose?

Any feedback or suggestions on this issue would be greatly appreciated! 😊

This issue is part of PR #2567 .

@xezon
Copy link
Collaborator

xezon commented Dec 15, 2024

  1. CheckBoxSaveCamera
    • Effect: On/Off save the player’s camera state for replays.
  2. CheckBoxUseCamera
    • Effect: On/Off the player’s camera during replays.

This is just for Single Player (Campaign, Skirmish) replays, correct?

  1. UI Restoration:
    • Which of these hidden controls should be restored to the UI? , I suugest the camera-related controls (CheckBoxSaveCamera, CheckBoxUseCamera)?

All that work should be ok. So 1 to 3 by the looks of it.

  1. General Guidance:
    • Are there any existing references or documentation about these controls to help clarify their purpose?

I am not aware about documentation for the cut options. You can check if there are any descriptions in generals.str about these things.

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker GUI For graphical user interface labels Dec 15, 2024
@DevGeniusCode
Copy link
Contributor Author

This is just for Single Player (Campaign, Skirmish) replays, correct?

This is how it looks.

Update:

ButtonKeyboardOptions

I found these strings in generals.str that seem to reference a screen intended to appear when pressing the button—a screen that allows editing hotkeys. However, these strings are located in the Edited folder, not in the folder containing the original files. This makes me wonder if this feature was added independently by someone else.
I couldn’t find any reference or mention of the Hotkey Edit screen in the wnd files.

GUI:KeyboardOptions
// context: Button to go to the keyboard options screen
"Keyboard Options"
END

GUI:CustomizeKeyboard
// context: Button to go to the keyboard customization screen
"Customize Keyboard"
END

GUI:Category
// context: category of keys. Keys are grouped by functionality
"Category"
END

GUI:Description
// context: key functionality description
"Description"
END

GUI:Commands
// context: Available commands
"Commands"
END

GUI:CurrentHotkey
// context: current key assigment
"Current Hotkey"
END

GUI:AssignNewHotkey
// context: button to assign a new key
"Assign New Hotkey"
END

GUI:CurrentlyAssignedTo
// context: current key assigment
"Currently Assigned To"
END

GUI:Assign
// context: button to assign a new key
"Assign"
END

GUI:ResetAll
// context: button to return to the default key assigments
"Reset All"
END

GUI:Reset
// context: button to return to the default key assigment
"Reset"
END

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Is new feature or request GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

No branches or pull requests

2 participants