Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve notificationPosition configuration #218

Closed
PdoubleU opened this issue Aug 18, 2023 · 2 comments
Closed

[FEATURE] Improve notificationPosition configuration #218

PdoubleU opened this issue Aug 18, 2023 · 2 comments
Assignees
Labels
🚀 enhancement New feature or request good first issue Good for newcomers 👋 help wanted Extra attention is needed

Comments

@PdoubleU
Copy link
Collaborator

PdoubleU commented Aug 18, 2023

Feature Request Requirements:

The existing notificationPosition attribute in the library doesn't provide enough positioning options, especially on larger screens like tablets.

Describe the solution you'd like:

I would like to expand the capabilities of the library by enhancing the notificationPosition attribute. Currently, the options are limited to top, center, and bottom. However, I propose adding the following additional options:

top-left
top-right
bottom-left
bottom-right

This expanded set of positioning options would offer greater flexibility in placing notifications on the screen, catering to various device sizes and layouts.

Describe alternatives you've considered

I've considered manually manipulating the notification positioning using custom styles or modifying the library's code directly. However, both of these approaches are less convenient and could potentially lead to maintenance challenges in the long run.

Additional context

Adding these new positioning options would greatly enhance the usability of the library, especially on larger screens where the existing options might not suffice. This change could contribute to a more responsive and user-friendly experience for applications built using react-native-notificated.

This solution could be an extension of this: #216, where @eleddie pointed out an issue with the notification width on tablets.

Customizing the width should also be supported by improving the notification's positioning on the screen.

@PdoubleU
Copy link
Collaborator Author

This is going to be resolved with #220

PdoubleU pushed a commit that referenced this issue Oct 31, 2023
* feature: notification width and position 
* closes #216 && #218
Co-authored-by: PdoubleU <[email protected]>
@PdoubleU
Copy link
Collaborator Author

closed with #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request good first issue Good for newcomers 👋 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants