PropsType is getting undefined

[bhavinatharva]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-video-player/index.js b/node_modules/react-native-video-player/index.js
index ed9965b..0d55654 100644
--- a/node_modules/react-native-video-player/index.js
+++ b/node_modules/react-native-video-player/index.js
@@ -606,58 +606,58 @@ export default class VideoPlayer extends Component {
   }
 }
 
-VideoPlayer.propTypes = {
-  video: Video.propTypes.source,
-  thumbnail: ImagePropTypes.source,
-  endThumbnail: ImagePropTypes.source,
-  videoWidth: PropTypes.number,
-  videoHeight: PropTypes.number,
-  duration: PropTypes.number,
-  autoplay: PropTypes.bool,
-  paused: PropTypes.bool,
-  defaultMuted: PropTypes.bool,
-  muted: PropTypes.bool,
-  style: ViewPropTypesVar.style,
-  controlsTimeout: PropTypes.number,
-  disableControlsAutoHide: PropTypes.bool,
-  disableFullscreen: PropTypes.bool,
-  loop: PropTypes.bool,
-  resizeMode: Video.propTypes.resizeMode,
-  hideControlsOnStart: PropTypes.bool,
-  endWithThumbnail: PropTypes.bool,
-  disableSeek: PropTypes.bool,
-  pauseOnPress: PropTypes.bool,
-  fullScreenOnLongPress: PropTypes.bool,
-  customStyles: PropTypes.shape({
-    wrapper: ViewPropTypesVar.style,
-    video: Video.propTypes.style,
-    videoWrapper: ViewPropTypesVar.style,
-    controls: ViewPropTypesVar.style,
-    playControl: ViewPropTypesVar.style,
-    controlButton: ViewPropTypesVar.style,
-    controlIcon: Icon.propTypes.style,
-    playIcon: Icon.propTypes.style,
-    seekBar: ViewPropTypesVar.style,
-    seekBarFullWidth: ViewPropTypesVar.style,
-    seekBarProgress: ViewPropTypesVar.style,
-    seekBarKnob: ViewPropTypesVar.style,
-    seekBarKnobSeeking: ViewPropTypesVar.style,
-    seekBarBackground: ViewPropTypesVar.style,
-    thumbnail: ImagePropTypes.style,
-    playButton: ViewPropTypesVar.style,
-    playArrow: Icon.propTypes.style,
-    durationText: ViewPropTypesVar.style
-  }),
-  onEnd: PropTypes.func,
-  onProgress: PropTypes.func,
-  onLoad: PropTypes.func,
-  onStart: PropTypes.func,
-  onPlayPress: PropTypes.func,
-  onHideControls: PropTypes.func,
-  onShowControls: PropTypes.func,
-  onMutePress: PropTypes.func,
-  showDuration: PropTypes.bool
-};
+// VideoPlayer.propTypes = {
+//   video: Video.propTypes.source,
+//   thumbnail: ImagePropTypes.source,
+//   endThumbnail: ImagePropTypes.source,
+//   videoWidth: PropTypes.number,
+//   videoHeight: PropTypes.number,
+//   duration: PropTypes.number,
+//   autoplay: PropTypes.bool,
+//   paused: PropTypes.bool,
+//   defaultMuted: PropTypes.bool,
+//   muted: PropTypes.bool,
+//   style: ViewPropTypesVar.style,
+//   controlsTimeout: PropTypes.number,
+//   disableControlsAutoHide: PropTypes.bool,
+//   disableFullscreen: PropTypes.bool,
+//   loop: PropTypes.bool,
+//   resizeMode: Video.propTypes.resizeMode,
+//   hideControlsOnStart: PropTypes.bool,
+//   endWithThumbnail: PropTypes.bool,
+//   disableSeek: PropTypes.bool,
+//   pauseOnPress: PropTypes.bool,
+//   fullScreenOnLongPress: PropTypes.bool,
+//   customStyles: PropTypes.shape({
+//     wrapper: ViewPropTypesVar.style,
+//     video: Video.propTypes.style,
+//     videoWrapper: ViewPropTypesVar.style,
+//     controls: ViewPropTypesVar.style,
+//     playControl: ViewPropTypesVar.style,
+//     controlButton: ViewPropTypesVar.style,
+//     controlIcon: Icon.propTypes.style,
+//     playIcon: Icon.propTypes.style,
+//     seekBar: ViewPropTypesVar.style,
+//     seekBarFullWidth: ViewPropTypesVar.style,
+//     seekBarProgress: ViewPropTypesVar.style,
+//     seekBarKnob: ViewPropTypesVar.style,
+//     seekBarKnobSeeking: ViewPropTypesVar.style,
+//     seekBarBackground: ViewPropTypesVar.style,
+//     thumbnail: ImagePropTypes.style,
+//     playButton: ViewPropTypesVar.style,
+//     playArrow: Icon.propTypes.style,
+//     durationText: ViewPropTypesVar.style
+//   }),
+//   onEnd: PropTypes.func,
+//   onProgress: PropTypes.func,
+//   onLoad: PropTypes.func,
+//   onStart: PropTypes.func,
+//   onPlayPress: PropTypes.func,
+//   onHideControls: PropTypes.func,
+//   onShowControls: PropTypes.func,
+//   onMutePress: PropTypes.func,
+//   showDuration: PropTypes.bool
+// };
 
 VideoPlayer.defaultProps = {
   videoWidth: 1280,

This issue body was partially generated by patch-package.

[hzhoanglee]

As I see, they are identical. Or am I missing something?

[mlazari]

As I see, they are identical. Or am I missing something?

@hzhoanglee I think you're missing that it's just commenting out those lines, not replacing them with something else. Video.propTypes is undefined with the latest react-native-video versions, which makes that code throw an error.

[github-actions]

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.

[Shivangi2909]

I am still facing same issue when using react-native-video version 6.8.2, react-native-video-player version0.14.0 and react-native version 0.76.3

[mlazari]

@Shivangi2909 I didn't try it yet, but I assume it should be fixed in the latest beta version, "react-native-video-player": "0.15.0-beta.3",.

[Shivangi2909]

@mlazari Thanks for the response, this version resolved the crash but it looks like its audioOnly prop is not working now which I was using earlier as well and its coming through react-native-video package

[mlazari]

@Shivangi2909 It looks like that prop was removed in react-native-video v6: https://github.com/TheWidlarzGroup/react-native-video/pull/3643/files#diff-56630fdf2c5199deee8ad0e128ccf342c26bfec7ecf3aa7c16a04bba0e186df0L189

[Shivangi2909]

@mlazari Any ideas on how we can make it work without patching the library or using a separate one for audio feature because even with 5.2.x version I am getting a different issue with latest RN version where this prop was working?

[mlazari]

@Shivangi2909 No, I think the only way would be to use version 5 of react-native-video and patch react-native-video-player 0.14.0