From 52cd733a72173c1af6d4c24bb77b35b4a0169ec5 Mon Sep 17 00:00:00 2001
From: mark-keaton <mark-keaton@users.noreply.github.com>
Date: Tue, 15 Oct 2024 15:17:24 -0500
Subject: [PATCH] RailwayStep logging improved. (#44)

---
 ChainSharp/Step/IStep.cs |  2 +-
 ChainSharp/Step/Step.cs  | 19 ++++++++++++-------
 Directory.Build.props    |  2 +-
 3 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/ChainSharp/Step/IStep.cs b/ChainSharp/Step/IStep.cs
index 24703f0..e867af0 100644
--- a/ChainSharp/Step/IStep.cs
+++ b/ChainSharp/Step/IStep.cs
@@ -6,5 +6,5 @@ public interface IStep<TIn, TOut>
 {
     public Task<TOut> Run(TIn input);
 
-    public Task<Either<Exception, TOut>> RailwayStep(Either<Exception, TIn> previousStep);
+    public Task<Either<Exception, TOut>> RailwayStep(Either<Exception, TIn> previousOutput);
 }
diff --git a/ChainSharp/Step/Step.cs b/ChainSharp/Step/Step.cs
index 1b249c3..4957c0e 100644
--- a/ChainSharp/Step/Step.cs
+++ b/ChainSharp/Step/Step.cs
@@ -8,16 +8,21 @@ public abstract class Step<TIn, TOut> : IStep<TIn, TOut>
 {
     public abstract Task<TOut> Run(TIn input);
 
-    public async Task<Either<Exception, TOut>> RailwayStep(Either<Exception, TIn> previousStep)
+    public async Task<Either<Exception, TOut>> RailwayStep(Either<Exception, TIn> previousOutput)
     {
-        if (previousStep.IsLeft)
-            return previousStep.Swap().ValueUnsafe();
+        if (previousOutput.IsLeft)
+            return previousOutput.Swap().ValueUnsafe();
 
-        Console.WriteLine($"Running Step ({previousStep.GetUnderlyingRightType().Name})");
+        var stepName = GetType().Name;
+        var previousOutputName = previousOutput.GetUnderlyingRightType().Name;
+
+        Console.WriteLine(
+            $"Running Step ({stepName}). Previous Output Type ({previousOutputName})"
+        );
 
         try
         {
-            return await Run(previousStep.ValueUnsafe());
+            return await Run(previousOutput.ValueUnsafe());
         }
         catch (Exception e)
         {
@@ -29,10 +34,10 @@ public async Task<Either<Exception, TOut>> RailwayStep(Either<Exception, TIn> pr
             if (messageField != null)
                 messageField.SetValue(
                     e,
-                    $"{{ \"Step\": \"{GetType().Name}\", \"Type\": \"{e.GetType().Name}\", \"Message\": \"{e.Message}\" }}"
+                    $"{{ \"step\": \"{stepName}\", \"type\": \"{e.GetType().Name}\", \"message\": \"{e.Message}\" }}"
                 );
 
-            Console.WriteLine($"Step: ({GetType().Name}) failed with Exception: ({e.Message})");
+            Console.WriteLine($"Step: ({stepName}) failed with Exception: ({e.Message})");
             return e;
         }
     }
diff --git a/Directory.Build.props b/Directory.Build.props
index 2450a83..5eac6ab 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -1,5 +1,5 @@
 <Project>
     <PropertyGroup>
-        <Version>2.2.0</Version>
+        <Version>2.2.1</Version>
     </PropertyGroup>
 </Project>