Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.x Images sizes issue with demo import #70

Open
AmentoTech opened this issue Dec 12, 2022 · 0 comments
Open

PHP 8.x Images sizes issue with demo import #70

AmentoTech opened this issue Dec 12, 2022 · 0 comments

Comments

@AmentoTech
Copy link

AmentoTech commented Dec 12, 2022

Hello @ViorelEremia

I hope you are doing well

We are a theme developer and have been working with Unyson and its demo content importer for a couple of years. PHP 7.4 is deprecated on many servers. Our many customers, facing issues with demo content import. This is not a big issue but stopping our customers to import demo content. We just got fixed that by adding a line of code. If you could add that fix quickly that would be much appreciated

8 1

This is fix 3f7665b
ext-8 1

Replace that line :

$state['processed_sizes'] = array_merge($state['processed_sizes'], $meta['sizes']);

with below

if(!empty($state['processed_sizes']) && !empty($meta['sizes'])){
    $state['processed_sizes'] = array_merge($state['processed_sizes'], $meta['sizes']);
}

Looking forward to fixing that asap, that would be much appreciated

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant