Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid sentence fragments in translations #80

Open
Findus23 opened this issue Sep 1, 2021 · 0 comments
Open

avoid sentence fragments in translations #80

Findus23 opened this issue Sep 1, 2021 · 0 comments

Comments

@Findus23
Copy link
Contributor

Findus23 commented Sep 1, 2021

Hi,

Just a quick comment I saw on weblate (and also noticed myself):

Sentence fragments like "was deleted" are pretty hard to translate in many languages as the correct form depends on what was deleted.

But it seems like in this case there is an easier solution anyway:

$errorList[]='Bot '.$botId.Piwik::translate('BotTracker_Message_deleted');

You could instead write something like

$errorList[] = Piwik::translate('BotTracker_Message_deleted', [$botId]);

with a key of Bot %s was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant