Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SignalSourceComplex #7

Open
EthnTuttle opened this issue Oct 17, 2024 · 1 comment
Open

Document SignalSourceComplex #7

EthnTuttle opened this issue Oct 17, 2024 · 1 comment
Labels
question Further information is requested

Comments

@EthnTuttle
Copy link

I am happy to make the PR but for the function but have a question:

    pub fn new(samp_rate: Float, freq: Float, amplitude: Float) -> Self {

Context: I'm looking at a SignalSource gnu-radio block and it has 5 values:
Sample Rate: 32k
Waveform: Cosine
Frequency: 1k
Amplitude: 100m
Offest: 0

Would SignaleSourceComplex::new(32000., 1000., 100000000) be a correct translation? (i'm newer to radio so perhaps this is common knowledge?)

@ThomasHabets
Copy link
Owner

Almost. I'm pretty sure 100m here means 100 milli, or 0.1.

Pluggable waveforms and offset are not yet implemented in rustradio.

To me the names samp_rate, freq, and amplitude are self documenting. But to be beginner friendly, I'd be happy to accept documenting PRs that would help other new people in the future.

@ThomasHabets ThomasHabets added the question Further information is requested label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants