Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustness against Deployments #25

Open
ThomasObenaus opened this issue Mar 24, 2019 · 2 comments
Open

Robustness against Deployments #25

ThomasObenaus opened this issue Mar 24, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ThomasObenaus
Copy link
Owner

Sokar modifies the job specification upon scaling the job. To be concrete the count of the job is modified.
Also the CI/CD system modifies the job specification without knowing the current count of the job that was set by sokar.
This conflicting knowledge/ information on both systems leads to the result that the CI/CD system will overwrite the count that was set by sokar and thus reverts the scaling.

@ThomasObenaus
Copy link
Owner Author

ThomasObenaus commented Mar 24, 2019

Options

1. Deployment through Sokar

  • Instead of directly talking to the nomad master the CI/CD system sends the deployment ticket to sokar, which then does the deployment

2. No count parameter in job-file

  • Probably consul-template works for the count parameter as well
  • Then it would be possible that the CI/CD system updates the job specification without alerting the count
  • Sokar then has to scale by modifying the according key in Consul

3. Merge current count into Job Spec

  • Instead of just overriding the job spec. during a deployment, the CI/CD system could just obtain the current count by getting the job spec from nomad. Then this number could just be replaced in the system.

4. Rescale directly if after external change

  • Sokar could watch the current count of the job spec and compare it against its internal knowledge/ desired count.
  • If it does not match the expectation, sokar could directly update the count.

@ThomasObenaus
Copy link
Owner Author

Option "4. Rescale directly if after external change" was implemented with #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant