Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work on Firefox 78 ESR #56

Open
Vintagemotors opened this issue Dec 30, 2023 · 9 comments
Open

Does not work on Firefox 78 ESR #56

Vintagemotors opened this issue Dec 30, 2023 · 9 comments
Labels
bug Something isn't working LegacyClient For issues with earlier Browser versions/ Legacy forks

Comments

@Vintagemotors
Copy link
Collaborator

Vintagemotors commented Dec 30, 2023 •
edited
Loading

Same behavior as MyPal68 but different logs

Logs

Uncaught (in promise) TypeError: Illegal constructor.
getInjectCSS moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:425
background.js:425:25
Security Error: Content at file:/// may not load data from blob:moz-extension://4f504fdd-9ba6-4ccb-8c34-32e9fdec1509/6f9dfb4d-13a1-4352-be98-88a7f65387b0.
NS_ERROR_DOM_BAD_URI: Component returned failure code: 0x805303f4 [nsIScriptSecurityManager.checkLoadURIWithPrincipal] ContentAreaDropListener.jsm:156
Security Error: Content at file:/// may not load data from blob:moz-extension://4f504fdd-9ba6-4ccb-8c34-32e9fdec1509/6f9dfb4d-13a1-4352-be98-88a7f65387b0.
NS_ERROR_DOM_BAD_URI: Component returned failure code: 0x805303f4 [nsIScriptSecurityManager.checkLoadURIWithPrincipal] ContentAreaDropListener.jsm:156
Error: Can't find profile directory. 2 XULStore.jsm:66:15
Loading failed for the <script> with source “blob:null/2f126529-3920-4cf3-9093-df1a699ee6fa”. blank:1:1
TypeError: PrecompiledScript.executeInGlobal: Argument 1 is not an object. 2 ExtensionContent.jsm:567:25
Loading failed for the <script> with source “blob:null/26517f14-4bfb-402d-9e51-6aabfd8131b4”. blank:1:1
Loading failed for the <script> with source “blob:null/826521b1-ed1a-4c73-9eca-3fad0c344a1d”. blank:1:1
Loading failed for the <script> with source “blob:null/a4a4ca32-8483-4003-bfbf-11254fcbce86”. blank:1:1
Type error for parameter contentScriptOptions (Error processing css.0: Value must either: contain the required "file" property, or .code must be a string value) for contentScripts.register. background.js:363
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
ondata moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2040
background.js:1734:29
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
ondata moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2040
background.js:1734:29
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:909
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:908
onstop moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2153
background.js:1734:29
Loading failed for the <script> with source “blob:null/9213ca37-dded-4b73-9145-f2d650a71872”. blank:1:1
Loading failed for the <script> with source “blob:null/bb406b33-75ad-4e6e-b051-5e56475e2cba”. blank:1:1
Type error for parameter contentScriptOptions (Error processing css.0: Value must either: contain the required "file" property, or .code must be a string value) for contentScripts.register. background.js:363
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
ondata moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2040
background.js:1734:29
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
ondata moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2040
background.js:1734:29
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:909
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:908
onstop moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2153
background.js:1734:29
Loading failed for the <script> with source “blob:null/b2a540c3-7538-4280-b6fa-11ab01aade74”. blank:1:1
TypeError: PrecompiledScript.executeInGlobal: Argument 1 is not an object. ExtensionContent.jsm:567:25
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:909
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:908
onstop moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2153
background.js:1734:29
Loading failed for the <script> with source “blob:null/427bedec-7a7c-498d-a3b1-3ae7170be551”. blank:1:1
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:909
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:908
onstop moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2153
background.js:1734:29
edit_str moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:1734
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:909
forEach self-hosted:225
parse_and_edit_html3 moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:908
onstop moz-extension://0f7e9ddf-634c-496c-b1b4-9928a7132093/background.js:2153

More logs

Error: Can't find profile directory. 2 XULStore.jsm:66:15
load resource://gre/modules/XULStore.jsm:66
XULStore resource://gre/modules/XULStore.jsm:24
TypeError: PrecompiledScript.executeInGlobal: Argument 1 is not an object. ExtensionContent.jsm:567:25
Uncaught (in promise) TypeError: Illegal constructor.
getInjectCSS moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:1698
background.js:1698:27
Type error for parameter contentScriptOptions (Error processing css.0: Value must either: contain the required "file" property, or .code must be a string value) for contentScripts.register. background.js:1621
makeError resource://gre/modules/Schemas.jsm:507
throwError resource://gre/modules/Schemas.jsm:2494
fixedArgs resource://gre/modules/Schemas.jsm:2562
map self-hosted:240
checkParameters resource://gre/modules/Schemas.jsm:2555
stub resource://gre/modules/Schemas.jsm:2661
setListener moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:1621
apply self-hosted:1870
applySafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:614
applySafe resource://gre/modules/ExtensionCommon.jsm:597
applySafe self-hosted:844
wrapPromise resource://gre/modules/ExtensionCommon.jsm:827
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
ondata moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2804
background.js:210:31
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
ondata moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2804
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
ondata moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2804
background.js:210:31
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
ondata moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2804
Uncaught (in promise) Max tries reached 2
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2199
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2197
onstop moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:3032
background.js:210:31
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2199
forEach self-hosted:225
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2197
onstop moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:3032
TypeError: PrecompiledScript.executeInGlobal: Argument 1 is not an object. ExtensionContent.jsm:567:25
Uncaught (in promise) Max tries reached
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2199
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2197
onstop moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:3032
background.js:210:31
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2199
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2197
onstop moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:3032
background.js:210:31
TypeError: PrecompiledScript.executeInGlobal: Argument 1 is not an object. ExtensionContent.jsm:567:25
Type error for parameter contentScriptOptions (Error processing css.0: Value must either: contain the required "file" property, or .code must be a string value) for contentScripts.register. background.js:1621
makeError resource://gre/modules/Schemas.jsm:507
throwError resource://gre/modules/Schemas.jsm:2494
fixedArgs resource://gre/modules/Schemas.jsm:2562
map self-hosted:240
checkParameters resource://gre/modules/Schemas.jsm:2555
stub resource://gre/modules/Schemas.jsm:2661
setListener moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:1621
apply self-hosted:1870
applySafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:614
applySafe resource://gre/modules/ExtensionCommon.jsm:597
applySafe self-hosted:844
wrapPromise resource://gre/modules/ExtensionCommon.jsm:827
Loading failed for the <script> with source “blob:null/84992cd5-1f74-482d-85f4-b919a1e6fa29”. blank:1:1
Type error for parameter contentScriptOptions (Error processing css.0: Value must either: contain the required "file" property, or .code must be a string value) for contentScripts.register. background.js:1621
makeError resource://gre/modules/Schemas.jsm:507
throwError resource://gre/modules/Schemas.jsm:2494
fixedArgs resource://gre/modules/Schemas.jsm:2562
map self-hosted:240
checkParameters resource://gre/modules/Schemas.jsm:2555
stub resource://gre/modules/Schemas.jsm:2661
setListener moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:1621
apply self-hosted:1870
applySafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:614
applySafe resource://gre/modules/ExtensionCommon.jsm:597
applySafe self-hosted:844
wrapPromise resource://gre/modules/ExtensionCommon.jsm:827
Uncaught (in promise) Max tries reached
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
ondata moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2804
background.js:210:31
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
ondata moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2804
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
ondata moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2804
background.js:210:31
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
ondata moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2804
Uncaught (in promise) Max tries reached 2
Uncaught TypeError: Illegal constructor.
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2199
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2197
onstop moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:3032
background.js:210:31
edit_str moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:210
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2199
forEach self-hosted:225
parse_and_edit_html3 moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:2197
onstop moz-extension://c062d33c-26c4-4956-934c-44e8bc7af2c2/background.js:3032
Uncaught (in promise) Max tries reached
@Vintagemotors Vintagemotors added bug Something isn't working LegacyClient For issues with earlier Browser versions/ Legacy forks labels Dec 30, 2023
@Vintagemotors
Copy link
Collaborator Author

I'm going to stop making separate issues for versions it won't run on, but it doesn't run on 91.0.1 ESR either.

@Vintagemotors
Copy link
Collaborator Author

Partially works on 102.15.1esr but flickers

@atomGit
Copy link

atomGit commented Jan 14, 2024

hey @Vintagemotors - thanks for helping out - i'm sure Thomaz appreciates it

as to the topic at hand, is there a logical reason to support old browsers? IMO, if people choose to run an outdated version -- and all the potential security issues that may go with that -- that's their problem

i think the oldest version any add-on should support is the latest ESR

@Vintagemotors
Copy link
Collaborator Author

as to the topic at hand, is there a logical reason to support old browsers? IMO, if people choose to run an outdated version -- and all the potential security issues that may go with that -- that's their problem

The extension's download page states that it supports Firefox 48 and above. Not everyone can or wants to run the latest version of Firefox, especially legacy users. A heavily modified version of 68 is the highest we can run on Windows XP and Vista 32 bit without custom kernel extensions. 78 is the highest we can run on MacOS 10.11 which is the cutoff for many 2nd Gen Macbook Pros and where many people with the dead dGPU issue are stuck. Also as I mentioned before, with their less robust error handling, earlier browser builds can help to identify issues that are being silently resolved in the background by newer releases. There are also other forks based on Gecko that do have current security patches but do not fully support some of the very latest WebExtension features. I'm not advocating for a major rewrite but if it were possible with a reasonable amount of effort and could also help find bugs in the process, I see no issue with trying to be compatible with those versions.

@ThomazPom
Copy link
Owner

ThomazPom commented Jan 17, 2024 •
edited
Loading

I appreciate your discussion on supporting older browsers.
Supporting the oldest browsers is one of the least prioritised aspects in my development plan but it remains a consideration.
My goal is to maintain compatibility without compromising the performance of non-obsolete browsers.
This can be done by implementing hooks with attached specialised methods that are only defined at start of Firefox under specific conditions relevant to older browsers. It then would be be easy to maintain these hooks and attached methods in a well isolated and documented browser-compatibility.js code file.
I'll also want to keep these specific functions very concise – just a few lines of code addressing specific behaviours.
My view is not immutable, and I'm open to further discussion and refinement.

@ThomazPom
Copy link
Owner

To achieve the performance of image editing, I employed processor threads. This necessitated the use of Workers, which, notably, do not offers to the conventional Canvas API but instead offers the OffscreenCanvas API. It's pertinent to mention that this API becomes available starting from Firefox version 105. This means supporting older browsers is not possible.

@Vintagemotors
Copy link
Collaborator Author

Would it be possible to publish a single build for legacy browsers with ImageEdition disabled and then just not maintain it?

@ThomazPom
Copy link
Owner

Best build with ImageEdition enabled will remain 1.5.36
We could detect browser version and disable ImageEdition if it's lower than 105

@ThomazPom
Copy link
Owner

ThomazPom commented Oct 8, 2024 •
edited
Loading

I Added an automatic compatibility mode mode in [1.5.67] wich disables imageEdition if Firefox is lower than 105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working LegacyClient For issues with earlier Browser versions/ Legacy forks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atomGit @ThomazPom @Vintagemotors