Broken site list

[chmichael]

ImageEdition related issues:

• Icons8 ImageEdition is not recoloring an image being used as a background for some elements
• Gaidourohora uses image as background, not being recolored by ImageEdition along with contrast text issue
• Pantazonas logo is not being recolored because ImageEdition thinks it should not be as it represents the brand.
• Mozilla Wiki on Service Workers ImageEdition not recoloring properly
• dermaesthete.gr (bright first page background and it darks only the text)
• cryptopotato.com (image edition doesn't show images)
• ab.gr/el/eshop/Vasika-typopoiimena-trofima/Konserves/Tonos-Tonosalata/Tonos-Fileto-Se-Ilielaio-2X140-gr/p/7139817 (it darkens the whole product image instead of the background only)
  (1.5.77)

Resolved:

• DYNU no apparent issue
• Blog post on DNS TTLS no apparent issue
• Pascal Game Development works when service worker compatibility is set to "Disabled"
• Ubuntu Server: Introduction to Active Directory Integration fallback to base html
• Proxmox Mail Gateway Overview no apparent issue
  (Results on 1.5.65)

[Vintagemotors]

@chmichael, the issues related to each feature should be categorized under the sections #6, #7, and #8, based on their specific breaks. However, if the behavioral issue is unique or different, it would be better to create individual issues for each. Partial darkening has been observed as the most prevalent issue.

Most Mozilla domains are protected. For protected sites to be affected, you would need to expressly disable the protection. This can be done by either editing the flag extensions.webextensions.restrictedDomains or allowing the extension to work on protected sites in extension settings.'

[chmichael]

DYNU no apparent issue

I don't think there isn't a issue. Check the screenshot for what i see

[ThomazPom]

I see this

[chmichael]

Found it! I have image edition disabled and it causes this

[chmichael]

btw, with Image Edition disabled firefox doesn't show the images in some sites. Seems there is a bug there

[ThomazPom]

I fixed a lot of things in imageEdition in versions 1.5.58 and 1.5.59.

[chmichael]

@ThomazPom

Well I wrote "disabled". eg dynu page with image edition disabled is rendered wrong but if i enable image edition the dynu site is displayed correctly!

I disable image edition because i don't like to darken the images of the sites.

[ThomazPom]

This is because this site uses an image as background.

[atomGit]

broken site: https://www.servocity.com/servos - there should be a lengthy table that loads listing all their servos but it doesn't load

fixed with ud 1.5.67

[rr1231234]

Wanna say this addon has improved a lot since I tried it months ago. All my everyday websites act really well with keeping the Image edition off. Looking forward for more improvements, like a button to show if the website is already excluded or not.

[chmichael]

@rr1231234 indeed! I guess in a couple months it will be better than "dark reader". They just need a better GUI to attract more people in my opinion.

[KeronCyst]

Waterfox G6.0.20 64-bit (Firefox ESR 115 core) on Windows 10 Home 22H2:

Google Sheets malfunctions in the spreadsheet itself, though the exterior is correctly darkened.

Wow, it goes totally bonkers on https://old.reddit.com/r/electricvehicles/ and probably many other subreddits.

[Vintagemotors]

@KeronCyst There are some artifacts and bugs relating to UltimaDark on older versions of Firefox ESR (For example Floorp had significantly more flashing along with some elements being generated by different JS libraries failing to load properly before they upgraded to ESR 128 core.) UltimaDark is listed as compatible because it does run, though at the moment I would not consider anything under 128 to be a "first class" experience using the latest versions of UltimaDark. Also could you please include the version of the extension with this issue by editing your original comment? I did a spot check with 1.5.62 under Floorp (ESR 115 core) and the subreddit you linked to appears to work fine aside from reddit's banner not being properly recolored (the subreddit banner remains unaffected and displays correctly.) I just checked with 1.5.70 and confirmed your issue. It appears to have been introduced by 1.5.63 and worsened? by 1.5.70

[atomGit]

text not readable, white BG: https://docs.axon-robotics.com/axon-servos/axon-max+

UD 1.5.77

[Vintagemotors]

@atomGit

text not readable, white BG: https://docs.axon-robotics.com/axon-servos/axon-max+

UD 1.5.77

Are you sure everything is enabled? It appears to be working correctly for me. (Tested on 1.5.62 and 1.5.77)
https://manual.edgetx.org/ which you mentioned on a different issue is another GitBook site that also appears to be working correctly with everything enabled.

[atomGit]

i keep image edition disabled, but i just tested again with it enabled and the result is the same - a nearly all white page, text is completely white - also tested with cache and workers enabled/disabled - did a hard refresh between all tests

result is the same for the edge.tx site

[atomGit]

tested the edgetx site again with a completely fresh profile and a default install of UD - result is the same; white page

[Vintagemotors]

tested the edgetx site again with a completely fresh profile and a default install of UD - result is the same; white page

That's so weird - I tested on versions of Floorp with ESR 115 and 128 core (on 2 different systems) and both have 0 issues. What version of Firefox is it? 132b2 has weird rendering issues without UltimaDark enabled so I'm not testing with it.

Screenshot

[atomGit]

FF 131.0.3

just tested again, fresh profile, default install...

Screenshot

[atomGit]

oh, wait a minute - just thought of something - i'm using a policies.json file - let me test without it

[atomGit]

...nope - same thing

[Vintagemotors]

Otherwise perhaps the issue is related to Firefox 131 then since I believe that is when I started seeing rendering issues. Also it looks like maybe you are on Linux? I haven't tested on anything other than Windows 10 since 1.5.45 since I assumed there shouldn't be compatibility differences but perhaps it has some sort of compositor conflict?

[atomGit]

Linux, yes - i don't have a windows box to test

if you can't reproduce, i'd say don't worry about it - we'll see if this changes down the road

[atomGit]

here's another one - all text and images in the main body of the page are not visible: https://www.smalladdictionsrc.com/radios-receivers-servos/

FF 131.0.3
UD 1.5.77

[ThomazPom]

https://docs.axon-robotics.com/axon-servos/axon-max+

Issue Reproduction and Analysis

I can reproduce this issue very easily and understand precisely why it occurs. It's a straightforward fix and can be resolved quickly.

Recent Discoveries and Improvements

While addressing this specific issue, I've made significant advancements in darkening techniques. These discoveries led me to recode substantial and core sections of UltimaDark. The updated structure is designed to enhance accessibility for other developers, without compromising quality.

Potential Impact

Given the scope of these changes, there may be some minor, easily resolvable regressions on certain websites. However, these will be addressed.

Resolution of this specific issue

This issue will be resolved soon in one of the upcoming releases that implies the new ultimaDark architecture and core.

[necaran]

• https://browserbench.org/Speedometer3.0/: JavaScript error. The test fails to finish since 1.6.0.
• https://cssloaders.github.io: JavaScript error. Content not loaded.
• https://www.getchu.com/anime/anime_newlist.html: Search not working due to normalized HTML structure.
  • Original:
    This one is tricky because the source HTML is incorrectly structured. The form element starts within div#search_nav at line 150 but closes outside of its parent node at line 172. Nevertheless, the submit button at line 172 still works because it is considered inside the form.
    
  • UltimaDark:
    After normalization, the form closes correctly within its parent node at line 120. However, the submit button becomes an orphan and therefore does nothing when clicked.
    
• https://finalfantasy.fandom.com/wiki/Final_Fantasy_IX_translations: Layout, HTML structure altered by UltimaDark.
  • Original:
    div#toc is the child of div.mw-parser-output.
    
  • UltimaDark:
    div#toc becomes the child of div#content.
    

[ThomazPom]

Fixed some regressions in 1.6.1 yet to be released:

• https://browserbench.org/Speedometer3.0/: JavaScript error. The test fails to finish since 1.6.0.
• https://cssloaders.github.io/: JavaScript error. Content not loaded.
• https://docs.axon-robotics.com/axon-servos/axon-max+
• https://finalfantasy.fandom.com/wiki/Final_Fantasy_IX_translations: Layout, HTML structure altered by UltimaDark.
  No idea how to hanfle yet :
  https://www.getchu.com/anime/anime_newlist.html: Search not working due to normalized HTML structure.

[necaran]

https://www.getchu.com/anime/anime_newlist.html: Search not working due to normalized HTML structure.

I found a solution by adding id to the form and the form attribute to form controls.
Form controls collections on the original DOM can be accessed like this.

document.querySelector('[name="formsearch"]').elements

So I can fix it by adding this in function parseAndEditHtmlContentBackend4.

    for (let i = 0; i < parsedDocument.forms.length; i++) {
        let form = parsedDocument.forms[i];
        if (!form.id)
            form.id = "_Form"+i;
        for(let e of form.elements)
            e.setAttribute("form", form.id);
    }