Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potato's "Extra crop chance" currently locked to a fixed 25% assumption #87

Open
AllUltima opened this issue Sep 6, 2024 · 1 comment

Comments

@AllUltima
Copy link

Please consider allowing a customization to the expected number of extra crops. There are a few reasons for this:

  • All extra crops are affected by daily luck. The special charm permanently changes daily luck, etc. For potatoes or for the last harvest on repeatable crops, it can situationally be desirable to just not harvest on bad-luck days. Such habits will produce a change in the expected profits.
  • Crop spots which will give extras are "repeatably random" if you restart the day. This is very exploitable with potatoes. With this in mind, any player willing to scum the day be restarting can simply choose not to harvest any potato that is not doubled. When the potatoes are planted earlier in the season, you can turn 100 seeds into 160 potatoes without too much problem.

I realize that to some extent the math in your app is assuming the player will replant as many times as possible before the end of the season. Regardless, for potatoes, if 25% were instead, say, 50%, that'd produce the overall math I'd like to see.

Since each crop has a different chance, I'd suggest naming the field "Expected Extra Crop Rate" with 100% for 'normal'.

(I get this is slightly advanced and a nuance for most players, I'd totally get if you decide to split into a simple/advanced view or something like that, or just tuck it away in a harder to find place)

@doodlebunnyhops
Copy link
Contributor

doodlebunnyhops commented Sep 23, 2024

I have a pr that addresses this though it's still work in progress as its the prediction model for all crops with extra chance or othrr scenarios. #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants