Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copy on lozenge for Award Dates #218

Open
mariongalley opened this issue Nov 8, 2023 · 4 comments
Open

Change copy on lozenge for Award Dates #218

mariongalley opened this issue Nov 8, 2023 · 4 comments
Labels
2023-refactor Related to the refactoring and COL tracker work

Comments

@mariongalley
Copy link

New Insights has slightly lengthier copy which is unnecessary (also not always accurate, as min-max is included even if only one of min or max is applied). Please update to match live Insights

New Insights copy: "Award date min - max"

Live Insights copy: "Award dates"

@mariongalley mariongalley added bug An error has occurred or something that is designed to work isn't working 2023-refactor Related to the refactoring and COL tracker work labels Nov 8, 2023
@michaelwood
Copy link
Member

Ah I did add that because there are two filters and I wanted to make it clearer which one was applied. (selecting a year, vs setting a min-max) technically you can do both so would end up with two "Award date" filter lozenge. This is the GrantNav equivalent e.g. https://grantnav.threesixtygiving.org/search?query=%2A&default_field=%2A&sort=_score+desc&min_amount=300&max_amount=50000&awardDate=2019

@michaelwood michaelwood added the question Further information is requested label Dec 11, 2023
@mariongalley
Copy link
Author

Ah right, that makes sense, thanks @michaelwood Although I found that if I first selected an award date and then added a min-max it didn't override the lozenge

@michaelwood
Copy link
Member

correction to GN url - https://grantnav.threesixtygiving.org/search?query=%2A&default_field=%2A&sort=_score+desc&min_date=10%2F2014&max_date=11%2F2019&awardDate=2019

GrantNav you can get into quite a mess, and annoyingly it hides the year selector afterwards. I think ideally in both GrantNav and Insights I would only allow one type of the two kinds of date (or amount) filters to be applied at any one time, however the UX of that would need properly thinking through.

@mariongalley
Copy link
Author

Agreed @michaelwood - not a blocker to live in any case

@michaelwood michaelwood removed bug An error has occurred or something that is designed to work isn't working question Further information is requested labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023-refactor Related to the refactoring and COL tracker work
Projects
None yet
Development

No branches or pull requests

2 participants