Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap out basic json schema validation with lib360dataquality #57

Open
michaelwood opened this issue Apr 9, 2024 · 1 comment
Open

Swap out basic json schema validation with lib360dataquality #57

michaelwood opened this issue Apr 9, 2024 · 1 comment

Comments

@michaelwood
Copy link
Member

Re-use dataquality / cove work to support extensions by using it as a library for the validation step. https://github.com/ThreeSixtyGiving/dataquality/tree/main/lib360dataquality
@michaelwood
Copy link
Member Author

We are also seeing divergence of options being passed to flattentool which produces different json output. This would be solved by just using the lib and the exact same options.

michaelwood added a commit that referenced this issue Sep 17, 2024
@michaelwood
get: unflatten make sure 'hashcomments' is switched on as in cove
9c1c431 
Publishers wishing for data to be ignored use a '#' in the data so mark
it up. This is switched on in the DQT (cove) but not on in the
datagetter's invocation of flattentool's unflatten.

Related: #57
@michaelwood michaelwood changed the title Swap out basic json schema validation with lib360dataquality to support extensions Swap out basic json schema validation with lib360dataquality Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelwood