-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Twitter with LinkedIn and place it before Github in tools footers #1104
Comments
mrshll1001
pushed a commit
that referenced
this issue
Sep 4, 2024
Had a go at resolving #1104 by doing simple find-and-replace, and introducing a new LinkedIn logo. Used the "reversed white" variant to match the other white logos we're using. Downloaded the logo from fontawesome and manipulated it in inkscape to match the rough dimensions of the other logos. * https://brand.linkedin.com/content/brand/global/en_us/index/visual-identity/logo * https://fontawesome.com/icons/linkedin?f=brands&s=solid Unsure as to whether this will look ok as not sure what the CSS is doing wrt to line height. Very happy for someone to come in and fix this if it's borked.
I've had a first stab at this. Lmk if I've seriously borked any CSS or SVG rendering. |
michaelwood
pushed a commit
that referenced
this issue
Sep 18, 2024
Had a go at resolving #1104 by doing simple find-and-replace, and introducing a new LinkedIn logo. Used the "reversed white" variant to match the other white logos we're using. Downloaded the logo from fontawesome and manipulated it in inkscape to match the rough dimensions of the other logos. * https://brand.linkedin.com/content/brand/global/en_us/index/visual-identity/logo * https://fontawesome.com/icons/linkedin?f=brands&s=solid Unsure as to whether this will look ok as not sure what the CSS is doing wrt to line height. Very happy for someone to come in and fix this if it's borked.
michaelwood
pushed a commit
that referenced
this issue
Sep 18, 2024
Had a go at resolving #1104 by doing simple find-and-replace, and introducing a new LinkedIn logo. Used the "reversed white" variant to match the other white logos we're using. Downloaded the logo from fontawesome and manipulated it in inkscape to match the rough dimensions of the other logos. * https://brand.linkedin.com/content/brand/global/en_us/index/visual-identity/logo * https://fontawesome.com/icons/linkedin?f=brands&s=solid Unsure as to whether this will look ok as not sure what the CSS is doing wrt to line height. Very happy for someone to come in and fix this if it's borked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From Ticket 50737
The text was updated successfully, but these errors were encountered: