Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations #176

Open
benbariteau opened this issue Jun 29, 2021 · 3 comments
Open

Add type annotations #176

benbariteau opened this issue Jun 29, 2021 · 3 comments
Labels
need more info question Further information is requested

Comments

@benbariteau
Copy link

No description provided.

@ethe
Copy link
Member

ethe commented Jun 30, 2021

Hi, could you please give more details about it?

@ethe ethe added need more info question Further information is requested labels Jun 30, 2021
@JonnoFTW
Copy link
Contributor

JonnoFTW commented Jul 7, 2021

@benbariteau if you want type hints for your thrift types, there is thriftpyi: https://github.com/unmade/thrift-pyi

@benbariteau
Copy link
Author

PEP 484 type hints are useful for anyone who wants to use a type checker, such as mypy. It would be nice if this library had them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need more info question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JonnoFTW @benbariteau @ethe