Merge pull request #701 from stevebroshar/replace-pointer-comparison-…

…with-null-checking Use null check instead of pointer comparison
ThrowTheSwitch · Oct 9, 2023 · b175905 · b175905
2 parents dcef17b + 7d0bcc8
commit b175905
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/unity.c b/src/unity.c
@@ -1609,8 +1609,8 @@ void UnityAssertEqualString(const char* expected,
         }
     }
     else
-    { /* handle case of one pointers being null (if both null, test should pass) */
-        if (expected != actual)
+    { /* fail if either null but not if both */
+        if (expected || actual)
         {
             Unity.CurrentTestFailed = 1;
         }
@@ -1649,8 +1649,8 @@ void UnityAssertEqualStringLen(const char* expected,
         }
     }
     else
-    { /* handle case of one pointers being null (if both null, test should pass) */
-        if (expected != actual)
+    { /* fail if either null but not if both */
+        if (expected || actual)
         {
             Unity.CurrentTestFailed = 1;
         }