Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini bug fix in sim.jl #207

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Mini bug fix in sim.jl #207

merged 1 commit into from
Nov 15, 2023

Conversation

juguma
Copy link
Contributor

@juguma juguma commented Nov 9, 2023

Replaced import w using, added ERR_MSG_CONT_TIME_MODE in sim.jl

Just FYI: yes, I am aware that with this commit I also modified import->using for EMPTY_fmi2Real, EMPTY_fmi2ValueReference. They are both used within the file w/o any package prefix, hence "using" is correct.

@ThummeTo
Copy link
Owner

Thanks. What bug is fixed by this?

@juguma
Copy link
Contributor Author

juguma commented Nov 10, 2023

None I did report before (because it was so tiny).
Without this commit I received the ERROR: UndefVarError: FMICore not defined, when calling fmiSimulate on my FMU. This error was thrown in the condition function of sim.jl. There are five other functions in sim.jl which use ERR_MSG_CONT_TIME_MODE as well.
I only assume that the same problem will appear whenever EMPTY_fmi2Real, or EMPTY_fmi2ValueReference is needed in the file, hence the fix for all three.
I can't share FMU and date, and it seems to much work for such a small issue trying to reproduce it with a smaller example.

@ThummeTo
Copy link
Owner

Tests are failing currently, this is because of #208
After this is resolved, we can merge

@ThummeTo ThummeTo merged commit 17ab2d0 into ThummeTo:main Nov 15, 2023
14 of 22 checks passed
@juguma juguma deleted the Bug_in_simjl24 branch November 15, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants