Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation images are broken #98

Open
sathvikbhagavan opened this issue Aug 14, 2023 · 9 comments
Open

Documentation images are broken #98

sathvikbhagavan opened this issue Aug 14, 2023 · 9 comments
Assignees

Comments

@sathvikbhagavan
Copy link

I am attaching a screenshot-

Screenshot 2023-08-14 at 5 34 31 PM
@ThummeTo
Copy link
Owner

Thanks for noticing. Examples are executed on the server and plots are generated and embedded... looks like there is something wrong with that pipeline now... Interestingly, the execution of the notebooks work, as you can see at the examples branch, so this might be something with the Documenter or the IPYNB to MD-converter. I will check after my holiday :-)

@ThummeTo ThummeTo added the help wanted Extra attention is needed label Sep 22, 2023
@sathvikbhagavan
Copy link
Author

I would be happy to take a look but where is the pipeline for building the docs? I am slightly confused as the main branch does not have the example files.

@ThummeTo
Copy link
Owner

Thanks!

The idea was to store the examples at a dedicated branch "examples", so the automatic pipeline does not commit to the "main" branch everytime it runs.

@ThummeTo ThummeTo removed the help wanted Extra attention is needed label Nov 8, 2023
@ThummeTo
Copy link
Owner

ThummeTo commented Nov 8, 2023

  • Fix Documenter (affects all examples) @0815Creeper
  • update examples to v0.13.0 @ThummeTo (mark outdated as "outdated")
  • allow for GIFs (affects JuliaCon example) @0815Creeper

@0815Creeper
Copy link
Contributor

on it

@0815Creeper
Copy link
Contributor

0815Creeper commented Nov 28, 2023

gif s are fixed

@ThummeTo
Copy link
Owner

@0815Creeper This is excellent, see!

@ThummeTo
Copy link
Owner

@0815Creeper this is fixed isnt it?

@0815Creeper
Copy link
Contributor

Until there is another jupyter/julia-kernel update, that breaks it again, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants