Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dangerous type piracy #2

Open
ChrisRackauckas opened this issue Oct 7, 2023 · 4 comments
Open

Dangerous type piracy #2

ChrisRackauckas opened this issue Oct 7, 2023 · 4 comments
Assignees
@ThummeTo

Comments

@ChrisRackauckas
Copy link

https://github.com/ThummeTo/FMISensitivity.jl/blob/main/src/FMISensitivity.jl#L40-L42 that's not great.
@ThummeTo
Copy link
Owner

ThummeTo commented Oct 7, 2023

Yep, you got me :)
Is there a reason why increment_deriv! is not defined for a ZeroTangent-increase?
In my head incrementing a TrackedReal by ZeroTangent shoud be defined, but just be a no-op.

If not, I need to dig deeper and prevent this call from happening...

@ThummeTo ThummeTo self-assigned this Oct 7, 2023
@ChrisRackauckas
Copy link
Author

If this is needed then upstream it?

ZeroTangent though is from ChainRules.jl, which ReverseDiff doesn't integrate with. This seems like however you did some chainrules thing forgot to handle this case.

@ThummeTo
Copy link
Owner

ThummeTo commented Oct 8, 2023

you are right, I will check for that... maybe the @grad_from_chainrules macro

1 similar comment
@ThummeTo
Copy link
Owner

ThummeTo commented Oct 8, 2023

you are right, I will check for that... maybe the @grad_from_chainrules macro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThummeTo ThummeTo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @ThummeTo