fix #14 #16
Merged
fix #14 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me @mohamed82008 - Please check if you find the time, I assigned you for review :-) |
Co-authored-by: Mohamed Tarek <[email protected]>
|
I think the test failures are related to ImplicitDifferentiation 0.4 changing their API using 3 arguments instead of 2. The tests need to be updated but it's not related to this PR. |
mohamed82008
approved these changes
May 24, 2023
|
bump |
|
Sorry for delay, I merged #17 first, so we can see if it's running now. |
ThummeTo
reviewed
Jun 19, 2023
There was a problem hiding this comment.
Looks like import FiniteDifferences is missing?
(test currently fail after mergin #17 )
Merged
ThummeTo
added a commit
that referenced
this pull request
Sep 14, 2023
* fix #14 (#16) * fix #14 * add FD * Update test/runtests.jl Co-authored-by: Mohamed Tarek <[email protected]> --------- Co-authored-by: Mohamed Tarek <[email protected]> Co-authored-by: ThummeTo <[email protected]> * version inc * added `FiniteDifferences` --------- Co-authored-by: Fredrik Bagge Carlson <[email protected]> Co-authored-by: Mohamed Tarek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to indicate that the function a rule is defined for is mutating its input argument.
Closes #14