Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: Support database checking checkAuth() #96

Open
TiE23 opened this issue Jul 12, 2018 · 1 comment
Open

Server: Support database checking checkAuth() #96

TiE23 opened this issue Jul 12, 2018 · 1 comment
Assignees
Labels
improvement It's not broken, but it can be better

Comments

@TiE23
Copy link
Owner

TiE23 commented Jul 12, 2018

Switching to using JWT instead of GraphQL hits to the database sped things up a lot, but it essentially means that if I ban an account they will have open access for as long as their JWT is valid and they do not log back in. I need to restore the option to have checkAuth check the database for the user's current status.

Restoring that step will not be difficult (just look at the diffs for ISSUE #78's branch), but deciding how to smartly re-check will be important.

Should I have pings to the server happen at random? For certain raised-sensitivity queries/mutations? For all mutations? Or should I look into tracking JWTs that were issued and have every checkAuth() hit that table and look for expired (in this case, forcibly) with every hit to the server and pray it's fast?

@TiE23 TiE23 added the improvement It's not broken, but it can be better label Jul 12, 2018
@TiE23 TiE23 self-assigned this Jul 12, 2018
@TiE23
Copy link
Owner Author

TiE23 commented Jan 14, 2019

Some thoughts later on:
I think all mutations should have a deep check.
I would like to maintain the checkAuth() function. So if possible make the deep check an optional argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement It's not broken, but it can be better
Projects
None yet
Development

No branches or pull requests

1 participant