Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add link Property for Character from tibia.com Website #381

Open
Skyliife opened this issue Aug 14, 2024 · 6 comments · May be fixed by #398
Open

Feature: Add link Property for Character from tibia.com Website #381

Skyliife opened this issue Aug 14, 2024 · 6 comments · May be fixed by #398
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Skyliife
Copy link

An enhancement to the current character data structure to include a link property that provides the URL to the character's profile on tibia.com. This would be useful for directly accessing the character's profile on the official website.

Proposed Change:

  1. Add a link property to the character object, which should contain the URL to the character's profile on tibia.com.
  2. The URL should replace spaces in the character's name with "+" to match the URL format used by tibia.com. e.g. character
    Atom Ironman => Atom+Ironman

Example:

The updated structure for the character object should look like this:

"character": {
      "account_status": "string",
      "achievement_points": 0,
      "comment": "string",
      "deletion_date": "string",
      "former_names": [
        "string"
      ],
      "former_worlds": [
        "string"
      ],
      "guild": {
        "name": "string",
        "rank": "string"
      },
      "houses": [
        {
          "houseid": 0,
          "name": "string",
          "paid": "string",
          "town": "string"
        }
      ],
      "last_login": "string",
      "level": 0,
      "married_to": "string",
      "name": "string",
      "position": "string",
      "residence": "string",
      "sex": "string",
      "title": "string",
      "traded": false,
      "unlocked_titles": 0,
      "vocation": "string",
      "world": "string",
      //new link property
      "link": "https://www.tibia.com/community/?name=Trollefar"
    },
@tobiasehlert
Copy link
Member

hi @Skyliife,
thanks for the suggestion, what about having that field in the information section and not mixed into the "data"-parts?

@tobiasehlert tobiasehlert added enhancement New feature or request good first issue Good for newcomers labels Aug 22, 2024
@tobiasehlert tobiasehlert self-assigned this Aug 22, 2024
@Skyliife
Copy link
Author

Skyliife commented Aug 27, 2024

@tobiasehlert also a good idea we could add guilds and other usefull links as well for example in the guild request?

@tobiasehlert
Copy link
Member

@tobiasehlert also a good idea we could add guilds and other usefull links as well for example in the guild request?

That would be something that is added on every endpoint the same way.

@Kai-Animator
Copy link

hey @tobiasehlert , can I work on this?

@tobiasehlert
Copy link
Member

hey @tobiasehlert , can I work on this?

Sure @Kai-Animator, submit a pull request and we can try to get it merged :)

@Kai-Animator
Copy link

hey @tobiasehlert , can I work on this?

Sure @Kai-Animator, submit a pull request and we can try to get it merged :)

Awesome :)
How would you prefer to see it done?
I considered adding link to the Information struct and do only the Character endpoint for now.
Otherwise I could be adding the tibia.com links to all the endpoints that require it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

3 participants