Add gif to image support and update imageMagick to 14.2 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heic images from IOS 18 cause problems for earlier versions of ImageMagick.net. dlemstra/Magick.NET#1753 This updates the library to 14.2.0. The library changed a bunch of int to uint, so this also casts all of the ints to uints.
RTnhN
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is really handy to be able to convert an animated gif to a still image. Most of the time, this just involves grabbing the first frame of the gif. This change implements that. In the future, the option to be able to select what frame to get should maybe be added, but for now this covers maybe 90% of the use cases for gif to img.
Another problem that I had that was also in #527 was that IOS with their HEIC file format did not convert. Only newer versions of ImageMagick fixed the problem, so I updated to 14.2. This required casting some variables from
inttouintthough.I installed it after building, and it works great.
Let me know what you think or if you have any suggestions for this. Thanks!
Closes #433
Closes #115
Closes #527
Closes #493
Closes #512