Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic of the clean and distclean targets in Makefile #34

Open
carnil opened this issue Sep 17, 2023 · 1 comment
Open

Logic of the clean and distclean targets in Makefile #34

carnil opened this issue Sep 17, 2023 · 1 comment

Comments

@carnil
Copy link
Contributor

carnil commented Sep 17, 2023

Hi

Currently the Makefile has:

distclean:                                                                                                            
        rm -f $(OBJS)

clean: distclean
        rm -f $(TARGET)*

According to https://www.gnu.org/software/make/manual/make.html shouldn't the logic in fact be inverted? https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html#Standard-Targets

In fact the distclean currently leaves around the built nodau binary, which should go away as well when running make distclean.
@carnil
Copy link
Contributor Author

carnil commented Sep 17, 2023

Noticed due to downstream report at https://bugs.debian.org/1049126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carnil