Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Loading indicator when tiddler is loading by loadTiddler() #4420

Closed
linonetwo opened this issue Jan 22, 2020 · 5 comments · Fixed by #8505
Closed

Feature: Loading indicator when tiddler is loading by loadTiddler() #4420

linonetwo opened this issue Jan 22, 2020 · 5 comments · Fixed by #8505

Comments

@linonetwo
Copy link
Contributor

When loading, tiddler's content will be blank, and without any indicator.

Is there a way to detect tiddler is being loading by SyncAdaptor, so I can add a loading indicator to it?

@Jermolene
Copy link
Member

Hi @linonetwo there's no support for that at present, but there's nothing stopping a syncadaptor from adding a view template segment with a loading indicator driven by its own data.

@linonetwo
Copy link
Contributor Author

What does view template segment mean?

Is there an API to update the title bar of a tiddler template programmatically? I think this is a little complex.

Seems there is a new syncer, will it handle tiddler level loading indicator?

@linonetwo
Copy link
Contributor Author

I think we can check _is_skinny and use a cascade for this.

@linonetwo
Copy link
Contributor Author

Done in tiddly-gittly/itonnote-plugin@fe10d9b in itonnote-plugin, build-in in TidGi app.

@Jermolene
Copy link
Member

Hi @linonetwo that implementation looks good – albeit I don't recommend using embedded stylesheets in that way.

I'd be happy to see this functionality in the core. I would handle the animation slightly differently, using a similar technique that the tiddlywebadaptor uses for animating the cloud icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants