Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RSOE from decodebase64 #8507

Open
twMat opened this issue Aug 11, 2024 · 4 comments
Open

[BUG] RSOE from decodebase64 #8507

twMat opened this issue Aug 11, 2024 · 4 comments

Comments

@twMat
Copy link
Contributor

twMat commented Aug 11, 2024

Describe the bug

RSOE from not-sure-what-to-call-this

text: {{{ [[http://tiddlywiki.com]decodebase64[]] }}}

Uncaught URIError: URI malformed

Expected behavior

No response

To Reproduce

type the above into a tiddler on e.g tiddlywiki.com and save the tiddler → error

Screenshots

No response

TiddlyWiki Configuration

tw 5.3.5 (e.g on tiddlywiki.com)
win11, brave browser

Additional context

No response

@twMat twMat changed the title [BUG] RSOE from decodebas64 [BUG] RSOE from decodebase64 Aug 11, 2024
@Leilei332
Copy link
Contributor

IMO the error should be displayed in the result of the filter expression instead of showing RSOE, like this:

IMG_20240830_183929.jpg

After all, I think we should implement "exception handling" for the operator to catch the error.

@twMat
Copy link
Contributor Author

twMat commented Aug 30, 2024

@Leilei332
Do you mean that a {{{ filtered transclusion }}} by itself should alert about errors? (because the OP has nothing to do with the search mechanism). Interesting!

@Leilei332
Copy link
Contributor

Leilei332 commented Aug 30, 2024

It is up to filter expression to alert about errors, and Tiddlywiki already supports displaying an error message when the filter expression syntax is wrong.

图片

The advanced search page is used to test the filter expression, and RSOE also appears when you type [[http://tiddlywiki.com]decodebase64[]] in the Filter tab.

图片

IMO the error is caused by inappropriate usage of the decodebase64 operator. I think we can display error message like Filter error: URI malformed when the exception is caught.

@Jermolene
Copy link
Member

Hi @twMat @Leilei332 we definitely don't want an RSOE. An error message as the response would indeed appear to be the best way forward. I would welcome a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants