Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Import-button creates a probably unnecessary huge DOM element #8167

Open
pmario opened this issue Apr 25, 2024 · 1 comment · May be fixed by #8590
Open

[Bug] Import-button creates a probably unnecessary huge DOM element #8167

pmario opened this issue Apr 25, 2024 · 1 comment · May be fixed by #8590

Comments

@pmario
Copy link
Member

pmario commented Apr 25, 2024

While messing with the transclusion detection I did find this one.

The cause is the import-button font-size is 999px, which was introduced 10 years ago. See: 7816c1d

@Jermolene Can you remember why it was set that way. If I remove that value from the stylesheet, the DOM seems to be fixed

See rigth sidebar -> tools -- I'm using the Edge browser to see the DOM levels.

image
@pmario pmario changed the title [But] Import-button creates a huge and probably unnecessary DOM element [Bug] Import-button creates a huge and probably unnecessary DOM element Apr 25, 2024
@pmario pmario changed the title [Bug] Import-button creates a huge and probably unnecessary DOM element [Bug] Import-button creates a probably unnecessary huge DOM element Apr 25, 2024
@Jermolene
Copy link
Member

Hi @pmario the approach TW uses for styling file inputs was standard stuff in 2013. I found a few references to it, but not sure which one I used back then:

https://l33tsource.com/blog/2013/07/21/Fancy-File-Upload-Buttons/

There may well be better options now that we don't need to worry about Internet Explorer etc.

@pmario pmario linked a pull request Sep 9, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unrealistic font-size from import-button pmario/TiddlyWiki5
2 participants
@Jermolene @pmario