From c9472ad295a0d7c65e2807a7857a10bfa2c0ad23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kalle=20Ahlstr=C3=B6m?= <kalle.ahlstrom@nitor.com>
Date: Wed, 15 May 2024 23:03:53 +0300
Subject: [PATCH] fix type errors from frontend

---
 packages/ilmomasiina-frontend/package.json                  | 2 +-
 .../src/routes/AuditLog/AuditLogActionFilter.tsx            | 2 +-
 .../src/routes/AuditLog/AuditLogItem.tsx                    | 4 ++--
 .../src/routes/Editor/components/EditorTabHeader.tsx        | 4 ++--
 .../src/routes/Editor/components/Questions.tsx              | 6 +++---
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/packages/ilmomasiina-frontend/package.json b/packages/ilmomasiina-frontend/package.json
index 342543c9..fa3302b0 100644
--- a/packages/ilmomasiina-frontend/package.json
+++ b/packages/ilmomasiina-frontend/package.json
@@ -2,7 +2,7 @@
   "name": "@tietokilta/ilmomasiina-frontend",
   "version": "2.0.0-alpha13",
   "scripts": {
-    "build": "vite build",
+    "build": "pnpm typecheck && vite build",
     "clean": "rimraf build dist",
     "start": "vite",
     "typecheck": "tsc --build"
diff --git a/packages/ilmomasiina-frontend/src/routes/AuditLog/AuditLogActionFilter.tsx b/packages/ilmomasiina-frontend/src/routes/AuditLog/AuditLogActionFilter.tsx
index 01927b56..4eb6ac95 100644
--- a/packages/ilmomasiina-frontend/src/routes/AuditLog/AuditLogActionFilter.tsx
+++ b/packages/ilmomasiina-frontend/src/routes/AuditLog/AuditLogActionFilter.tsx
@@ -20,7 +20,7 @@ const ACTIONS = [
   [AuditEvent.DELETE_USER, 'auditLog.filter.action.deleteUser'],
   [AuditEvent.RESET_PASSWORD, 'auditLog.filter.action.resetPassword'],
   [AuditEvent.CHANGE_PASSWORD, 'auditLog.filter.action.changeOwnPassword'],
-];
+] as const;
 
 const AuditLogActionFilter = () => {
   const dispatch = useTypedDispatch();
diff --git a/packages/ilmomasiina-frontend/src/routes/AuditLog/AuditLogItem.tsx b/packages/ilmomasiina-frontend/src/routes/AuditLog/AuditLogItem.tsx
index 1cc0a570..66a1a64e 100644
--- a/packages/ilmomasiina-frontend/src/routes/AuditLog/AuditLogItem.tsx
+++ b/packages/ilmomasiina-frontend/src/routes/AuditLog/AuditLogItem.tsx
@@ -12,7 +12,7 @@ type Props = {
   item: AuditLogItemSchema;
 };
 
-const ACTION_STRINGS: Record<AuditEvent, string> = {
+const ACTION_STRINGS = {
   [AuditEvent.CREATE_EVENT]: 'auditLog.description.createEvent',
   [AuditEvent.EDIT_EVENT]: 'auditLog.description.editEvent',
   [AuditEvent.PUBLISH_EVENT]: 'auditLog.description.publishEvent',
@@ -25,7 +25,7 @@ const ACTION_STRINGS: Record<AuditEvent, string> = {
   [AuditEvent.DELETE_USER]: 'auditLog.description.deleteUser',
   [AuditEvent.RESET_PASSWORD]: 'auditLog.description.resetPassword',
   [AuditEvent.CHANGE_PASSWORD]: 'auditLog.description.changeOwnPassword',
-};
+} as const;
 
 function useItemDescription(item: AuditLogItemSchema) {
   const { t } = useTranslation();
diff --git a/packages/ilmomasiina-frontend/src/routes/Editor/components/EditorTabHeader.tsx b/packages/ilmomasiina-frontend/src/routes/Editor/components/EditorTabHeader.tsx
index 046e4151..38b74df9 100644
--- a/packages/ilmomasiina-frontend/src/routes/Editor/components/EditorTabHeader.tsx
+++ b/packages/ilmomasiina-frontend/src/routes/Editor/components/EditorTabHeader.tsx
@@ -14,13 +14,13 @@ export enum EditorTab {
   SIGNUPS = 'signups',
 }
 
-const tabTitles: Record<EditorTab, string> = {
+const tabTitles = {
   [EditorTab.BASIC_DETAILS]: 'editor.tabs.basic',
   [EditorTab.QUOTAS]: 'editor.tabs.quotas',
   [EditorTab.QUESTIONS]: 'editor.tabs.questions',
   [EditorTab.EMAILS]: 'editor.tabs.emails',
   [EditorTab.SIGNUPS]: 'editor.tabs.signups',
-};
+} as const;
 
 type TabProps = Props & {
   id: EditorTab;
diff --git a/packages/ilmomasiina-frontend/src/routes/Editor/components/Questions.tsx b/packages/ilmomasiina-frontend/src/routes/Editor/components/Questions.tsx
index d53fd8f9..2df2a171 100644
--- a/packages/ilmomasiina-frontend/src/routes/Editor/components/Questions.tsx
+++ b/packages/ilmomasiina-frontend/src/routes/Editor/components/Questions.tsx
@@ -87,7 +87,7 @@ const QuestionRow = ({ name, index, remove }: QuestionProps) => {
           required
           options={[
             [QuestionType.TEXT, t('editor.questions.questionType.text')],
-            [QuestionType.TEXT_AREA, t('editor.questions.questionType.textArea')],
+            [QuestionType.TEXT_AREA, t('editor.questions.questionType.textarea')],
             [QuestionType.NUMBER, t('editor.questions.questionType.number')],
             [QuestionType.SELECT, t('editor.questions.questionType.select')],
             [QuestionType.CHECKBOX, t('editor.questions.questionType.checkbox')],
@@ -159,8 +159,8 @@ const Questions = () => {
   const keys = useShallowMemo(fields.value.map((item) => item.key));
   const questionItems = useMemo(() => fields.map((name, i) => (
     <QuestionRow key={keys[i]} name={name} index={i} remove={fields.remove} />
-  // This list only invalidates when the question positions or count change.
-  // eslint-disable-next-line react-hooks/exhaustive-deps
+    // This list only invalidates when the question positions or count change.
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   )), [keys]);
 
   return (