Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Make invoice success text larger #492

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JaaskelainenL
Copy link

@JaaskelainenL JaaskelainenL commented Sep 11, 2024

The text has been made bigger so it's easier to read. Now the size is 2xl.

Closes #482

Description

Fixes #482

Before submitting the PR, please make sure you do the following

  • [ X] If your PR is related to a previously discussed issue, please link to it here.
  • [ X] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [X ] This message body should clearly illustrate what problems it solves.
  • [ X] Make sure the commit history is linear, up-to-date with main branch and does not contain any erroneous changes

Formatting and linting

  • [ X] Format code with pnpm format and lint the project with pnpm lint

@MikaelSiidorow
Copy link
Collaborator

I think we could also style it more nicely in addition to increasing the size 😅 Either with some sort of toast implementation or other type of success cards. The landing page announcements are probably a good place to get inspiration from
image

Could be a simplified version of the card above 🤔

Does @ellimattila have any design ideas or comments? For form success and error feedback?

@JaaskelainenL
Copy link
Author

That's fair. Are there any other sites with confirmation messages which could be used for reference?

@MikaelSiidorow
Copy link
Collaborator

That's fair. Are there any other sites with confirmation messages which could be used for reference?

Ilmo and laskugeneraattori use the same confirmation message, both just have a green text.

@ellimattila made some designs for a toast, which would probably pop up in the bottom right, or some other corner? We would probably need to set up some toaster lib for that. I think we should probably merge this quick fix for now and make a new issue about toasts

@MikaelSiidorow
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show larger success message after sending invoice in invoice generator
2 participants