rename maximize param

[ 72%] Building CXX object vncviewer/CMakeFiles/vncviewer.dir/DesktopWindow.cxx.o
/Users/fedo/repos/tigervnc/vncviewer/DesktopWindow.cxx:177:7: error: reference to non-static member function must be called; did you mean to call it with no arguments?
  177 |   if (maximize) {
      |       ^~~~~~~~
      |               ()
/Users/fedo/repos/tigervnc/vncviewer/DesktopWindow.cxx:177:7: error: value of type 'void' is not contextually convertible to 'bool'
  177 |   if (maximize) {
      |       ^~~~~~~~
2 errors generated.
make[2]: *** [vncviewer/CMakeFiles/vncviewer.dir/DesktopWindow.cxx.o] Error 1
make[1]: *** [vncviewer/CMakeFiles/vncviewer.dir/all] Error 2
make: *** [all] Error 2

Author: phedoreanu

vncviewer/DesktopWindow.cxx

@@ -172,9 +172,9 @@ DesktopWindow::DesktopWindow(int w, int h, const char *name,
   }
 
 #ifdef __APPLE__
-  // On OS X we can do the maximize thing properly before the
-  // window is showned. Other platforms handled further down...
-  if (maximize) {
+  // On OS X we can do the maximizeParam thing properly before the
+  // window is shown. Other platforms handled further down...
+  if (maximizeWindow) {
     int dummy;
     Fl::screen_work_area(dummy, dummy, w, h, geom_x, geom_y);
   }
@@ -208,7 +208,7 @@ DesktopWindow::DesktopWindow(int w, int h, const char *name,
   // maximized property on Windows and X11 before showing the window.
   // See STR #2083 and STR #2178
 #ifndef __APPLE__
-  if (maximize) {
+  if (maximizeParam) {
     maximizeWindow();
   }
 #endif

vncviewer/parameters.cxx

@@ -106,7 +106,7 @@ IntParameter qualityLevel("QualityLevel",
                           "JPEG quality level. 0 = Low, 9 = High",
                           8);
 
-BoolParameter maximize("Maximize", "Maximize viewer window", false);
+BoolParameter maximizeParam("Maximize", "Maximize viewer window", false);
 BoolParameter fullScreen("FullScreen", "Enable full screen", false);
 StringParameter fullScreenMode("FullScreenMode", "Specify which monitors to use when in full screen. "
                                                  "Should be either Current, Selected or All",

vncviewer/parameters.h

@@ -48,7 +48,7 @@ extern rfb::IntParameter compressLevel;
 extern rfb::BoolParameter noJpeg;
 extern rfb::IntParameter qualityLevel;
 
-extern rfb::BoolParameter maximize;
+extern rfb::BoolParameter maximizeParam;
 extern rfb::BoolParameter fullScreen;
 extern rfb::StringParameter fullScreenMode;
 extern rfb::BoolParameter fullScreenAllMonitors; // deprecated