Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client dark mode support #1658

Open
RokeJulianLockhart opened this issue Aug 20, 2023 · 3 comments
Open

Client dark mode support #1658

RokeJulianLockhart opened this issue Aug 20, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Aug 20, 2023

Is your feature request related to a problem? Please describe.

I have applied a dark system theme via the undermentioned methods:

  • #!/usr/bin/env -S sh
    # kcmshell6 --list
    kcmshell6
  • systemsettings

  • #!/usr/bin/env -S sh
    # lookandfeeltool --list
    lookandfeeltool --apply 'org.kde.breezedark.desktop'

...as demonstrated (by the undermentioned screenshot):

image

...yet TigerVNC remains unaffected by this (per the undermentioned screenshot):

image

...which is in stark contrast to everything else I've ever used.

Describe the solution you'd like

Adhere to system theme preferences.

Describe alternatives you've considered

At the very least, provide a custom theming system so that I can maintain one that replaces Breeze.

@CendioOssman CendioOssman changed the title Adhere to the colouration of the host. Client dark mode support Aug 21, 2023
@CendioOssman
Copy link
Member

This is unfortunately more of an issue of the @fltk GUI toolkit we use, which currently has no dark mode support (and not much in the way of theming either). So it likely requires some new features there first.

But we can have a tracker issue here to keep an eye on it from our end.

@CendioOssman CendioOssman added the enhancement New feature or request label Aug 21, 2023
@timothytylee
Copy link

This is unfortunately more of an issue of the @fltk GUI toolkit we use, which currently has no dark mode support (and not much in the way of theming either). So it likely requires some new features there first.

But we can have a tracker issue here to keep an eye on it from our end.

I've created PR #1846 which attempts to implement dark mode in FLTK.

@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Oct 13, 2024

fltk/fltk#870 (comment) appears to track fixing this upstream.

However, since all the issues like fltk/fltk#972 (comment) that I've seen – about adherence to system colouration, irrespective of darkness – appear solved, I'm surprised TigerVNC doesn't adhere by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants