Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent code snippet imports #91

Open
matteosantama opened this issue Jan 19, 2021 · 2 comments
Open

Inconsistent code snippet imports #91

matteosantama opened this issue Jan 19, 2021 · 2 comments

Comments

@matteosantama
Copy link

pg. 119 has the following code snippet

from typing import Iterator
X = TypeVar('X')

def iterate(step: Callable[[X], X], start: X) -> Iterator[X]:
    ...

It seems odd to explicitly import Iterator from typing, but not Callable or TypeVar.

@matteosantama
Copy link
Author

Looks like this will be closed by #61

@coverdrive
Copy link
Collaborator

Thanks. We need to do a pass through the book to handle these inconsistencies in what imports are shown and what aren't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants