Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a "cleanup" or "delete" action #16

Open
ctron opened this issue Jun 16, 2021 · 5 comments
Open

Provide a "cleanup" or "delete" action #16

ctron opened this issue Jun 16, 2021 · 5 comments

Comments

@ctron
Copy link

ctron commented Jun 16, 2021

Following the idea of https://github.com/machulav/ec2-github-runner to start an "on demand" GitHub actions runner at Hetzner I found that this action can be configured to not delete the instance after the (setup) job has run. But in the end, one needs to clean up the instance.

It would be great if there would be an "out of the box" solution for this, similar to this "deploy-server-action".

@TimDaub
Copy link
Owner

TimDaub commented Jun 16, 2021

Hi @ctron, thanks for contributing. I'm not sure I follow your idea. I'll take a closer look later. In the meantime, are you aware of the delete-server input? https://github.com/TimDaub/hetzner-cloud-deploy-server-action#notes

@TimDaub
Copy link
Owner

TimDaub commented Jun 16, 2021

Btw. I'm happy to merge additional functionality. Feel free to propose PRS

@ctron
Copy link
Author

ctron commented Jun 16, 2021

Hi @ctron, thanks for contributing. I'm not sure I follow your idea. I'll take a closer look later. In the meantime, are you aware of the delete-server input? https://github.com/TimDaub/hetzner-cloud-deploy-server-action#notes

Yes, I am. But to my understanding, that just leaves the server running. But there is no way to kill it later?!

@TimDaub
Copy link
Owner

TimDaub commented Aug 10, 2021

If delete-server: true it kills it after all GitHub Actions have run in the post-cleanup action. You can also set delete-server: false and shutdown/delete the server yourself manually using Hetzner's API.

@ctron
Copy link
Author

ctron commented Aug 11, 2021

You can also set delete-server: false and shutdown/delete the server yourself manually using Hetzner's API.

That is what I am doing now. But it would be great to have a GitHub action for this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants