Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade material ui dependency to v5. #189

Open
LeifAndersen opened this issue Apr 23, 2023 · 5 comments
Open

Upgrade material ui dependency to v5. #189

LeifAndersen opened this issue Apr 23, 2023 · 5 comments

Comments

@LeifAndersen
Copy link

Right now this library uses material ui v4. It looks like that its no longer being maintained since v5 has come out:

https://www.npmjs.com/package/@material-ui/core

Unfortunately, it also looks like v4 relies on react 17, and fails on react 18. As such, chonky also seems to require react 17.

@SkippyHub
Copy link

bump

 WARN  Issues with peer dependencies found
.
└─┬ chonky 2.3.2
  ├─┬ @material-ui/core 4.11.3
  │ ├── ✕ unmet peer react@"^16.8.0 || ^17.0.0": found 18.2.0
  │ ├── ✕ unmet peer react-dom@"^16.8.0 || ^17.0.0": found 18.2.0
  │ ├─┬ @material-ui/styles 4.11.5
  │ │ ├── ✕ unmet peer react@"^16.8.0 || ^17.0.0": found 18.2.0
  │ │ ├── ✕ unmet peer react-dom@"^16.8.0 || ^17.0.0": found 18.2.0
  │ │ └─┬ @material-ui/utils 4.11.3
  │ │   ├── ✕ unmet peer react@"^16.8.0 || ^17.0.0": found 18.2.0
  │ │   └── ✕ unmet peer react-dom@"^16.8.0 || ^17.0.0": found 18.2.0
  │ └─┬ @material-ui/system 4.12.2
  │   ├── ✕ unmet peer react@"^16.8.0 || ^17.0.0": found 18.2.0
  │   └── ✕ unmet peer react-dom@"^16.8.0 || ^17.0.0": found 18.2.0
  └─┬ react-intl 5.25.1
    ├── ✕ unmet peer typescript@^4.5: found 5.0.4
    └─┬ @formatjs/intl 2.2.1
      └── ✕ unmet peer typescript@^4.5: found 5.0.4
      ```

@michaelpward
Copy link

Chonky will die a quick death if key dependencies are not kept up to date. 👍🏼

@LeifAndersen
Copy link
Author

Since it looks like this project hasn't had any updates in over a year, I suspect it may already be too late. :(

FWIW, as a temporary (pretty awful) patch, you 'might' be able to get around this by putting this in your package.json:

  "overrides": {
    "react": "$react"
  }

@dominique-mueller
Copy link

@TimboKZ Would you accept a PR on this?

@divyam234
Copy link

divyam234 commented Jun 29, 2023

@dominique-mueller @LeifAndersen Try this updated version https://github.com/aperturerobotics/react-chonky. I have also done the whole migration in emotion and muiv5 and some general tweaks like Material 3, virtuoso for better performance on virtual lists and also removed dependency on icon packages (both in one) you can check my fork also here https://github.com/divyam234/react-chonky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants